Skip to content

Conversation

@olzzon
Copy link

@olzzon olzzon commented Jun 5, 2024

About the Contributor

This PR is made on behalf of BBC

Type of Contribution

Feature
This is a:

Bug fix / Feature / Code improvement / Documentation improvement / Other (please specify)

Current Behavior

Currently Package Containers can only be added in Settings

New Behavior

Package Containers has been converted WithOverrides, and are now able to be configured from Blueprints

Testing Instructions

Add PackageContainers as part of the config:

	return {
		mappings: getMappings(context, config),
		playoutDevices,
		ingestDevices: {},
		inputDevices: {},
		packageContainers: {
			casparcgContainer0: {
				deviceIds: ['casparClipServer'],
				container: {
					label: 'Test Container',
					accessors: {
						casparcgHttpProxy0: {
							type: Accessor.AccessType.HTTP_PROXY,
							label: 'casparcgHttpProxyAccessor',
							allowRead: true,
							allowWrite: true,
							baseUrl: 'http://192.168.1.109:8080/media',
						},
					},
				},
			},
		},
	}

Time Frame

This is supposed to be merged after #6
As the changed has been basen on improvements from that

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

olzzon and others added 30 commits March 26, 2024 13:13
Co-authored-by: Johan Nyman <johan@nytamin.se>
…witchrouteSet() from playoutModel and ServerPlayoutAPI

Co-authored-by: Julian Waller <Julusian@users.noreply.github.com>
…o StudioBaselineHelper and align naimg between playoutmodel and studioplayoutmodel
…eactivation other routesets not for activation.
…import types into bp integration api studio.ts
…rrides

Co-authored-by: Johan Nyman <johan@nytamin.se>
@Julusian Julusian changed the base branch from release51 to feat/routeset-config-defined-in-blueprints September 19, 2024 11:16
Copy link
Collaborator

@Julusian Julusian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are also a few type error being emitted by meteor in this branch. Some will be fixed by the review comments, but it would be good to verify they are all gone when done

@Julusian Julusian changed the title Feat/config package manager from blueprints Feat/config package manager from blueprints SOFIE-91 Sep 19, 2024
Copy link

@PeterC89 PeterC89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality looks good aside from the setting package containers as preview etc.
Let's get this merged upstream and pick the remaining bits up later

@Julusian Julusian marked this pull request as ready for review September 23, 2024 14:58
@Julusian Julusian changed the base branch from feat/routeset-config-defined-in-blueprints to upstream/config-package-manager-from-blueprints September 23, 2024 14:58
@Julusian Julusian merged commit 838ff62 into upstream/config-package-manager-from-blueprints Sep 23, 2024
@Julusian Julusian deleted the feat/config-package-manager-from-blueprints branch September 23, 2024 15:09
@Julusian Julusian restored the feat/config-package-manager-from-blueprints branch September 23, 2024 15:18
@Julusian
Copy link
Collaborator

Upstream: Sofie-Automation#1263

@Julusian Julusian deleted the feat/config-package-manager-from-blueprints branch October 21, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants