-
Notifications
You must be signed in to change notification settings - Fork 1
Feat/config package manager from blueprints SOFIE-91 #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/config package manager from blueprints SOFIE-91 #10
Conversation
Co-authored-by: Johan Nyman <johan@nytamin.se>
…ntegration triggerds
…eprints adlibActions.ts
…witchrouteSet() from playoutModel and ServerPlayoutAPI Co-authored-by: Julian Waller <Julusian@users.noreply.github.com>
…o StudioBaselineHelper and align naimg between playoutmodel and studioplayoutmodel
…into saveAllToDatabase()
…amed to switchroueSet()
…tive Db update to promise.all.
…eactivation other routesets not for activation.
…onTrigger implementation
…import types into bp integration api studio.ts
…ToDo import BlueprintMapping and TSR
…pplyStudioConfig for backward compatibility
…rrides Co-authored-by: Johan Nyman <johan@nytamin.se>
…onfig-package-manager-from-blueprints
Julusian
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are also a few type error being emitted by meteor in this branch. Some will be fixed by the review comments, but it would be good to verify they are all gone when done
meteor/server/publications/packageManager/expectedPackages/generate.ts
Outdated
Show resolved
Hide resolved
meteor/server/publications/packageManager/expectedPackages/generate.ts
Outdated
Show resolved
Hide resolved
meteor/server/publications/pieceContentStatusUI/checkPieceContentStatus.ts
Outdated
Show resolved
Hide resolved
meteor/server/publications/pieceContentStatusUI/__tests__/checkPieceContentStatus.test.ts
Outdated
Show resolved
Hide resolved
meteor/server/publications/pieceContentStatusUI/checkPieceContentStatus.ts
Outdated
Show resolved
Hide resolved
… of loops and share it with getAssets
PeterC89
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality looks good aside from the setting package containers as preview etc.
Let's get this merged upstream and pick the remaining bits up later
…onfig-package-manager-from-blueprints
|
Upstream: Sofie-Automation#1263 |
About the Contributor
This PR is made on behalf of BBC
Type of Contribution
Feature
This is a:
Bug fix / Feature / Code improvement / Documentation improvement / Other (please specify)
Current Behavior
Currently Package Containers can only be added in Settings
New Behavior
Package Containers has been converted WithOverrides, and are now able to be configured from Blueprints
Testing Instructions
Add PackageContainers as part of the config:
Time Frame
This is supposed to be merged after #6
As the changed has been basen on improvements from that
Status