Skip to content

Conversation

@olzzon
Copy link

@olzzon olzzon commented Apr 17, 2024

About the Contributor

This PR is made on the behalf of BBC

Type of Contribution

This is a:
Feature / Code improvement

Current Behavior

routSets and routeSetExclusivityGroups can only be configured in settings, and can only be changed in the switchboard.

New Behavior

routeSet and routeSetExclusivityGroups can now be configured and controlled from blueprints.
routeSet changes can be applied via actions.

Following major changes had been made in the code:

  • routSets and routeSetExclusivityGroups has been converted to ObjectsWithOverrides in core and libs.
    • routSets and routeSetExclusivityGroups are of cause without overrides in the blueprints integration.
  • Routings.tsx has been converted to functional component to use the Overrides Hooks.
  • overrideOpHelper.ts has been moved to corelib with exports to the React OverrideOpHelper.tsx
  • OverrideOpHelper.tsx has been moved to ui/utils
  • Migrations to release51 has been added in X_X_X.ts

Testing Instructions:

Implementation in Blueprints can look something like:

export function getRouteSets(_context: ICommonContext, config: StudioConfig): StudioRouteSets {
	console.log(config)
	const routeSets: StudioRouteSets = {}

	routeSets['first-route'] = {
		name: 'First Route',
		active: true,
		behavior: StudioRouteBehavior.ACTIVATE_ONLY,
		routes: [
                     -----------
                ],
	}
	return routeSets
}

Time Frame

This should be part of Release51

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

olzzon and others added 30 commits March 26, 2024 13:13
Co-authored-by: Johan Nyman <johan@nytamin.se>
…witchrouteSet() from playoutModel and ServerPlayoutAPI

Co-authored-by: Julian Waller <Julusian@users.noreply.github.com>
…o StudioBaselineHelper and align naimg between playoutmodel and studioplayoutmodel
…eactivation other routesets not for activation.
…import types into bp integration api studio.ts
…rrides

Co-authored-by: Johan Nyman <johan@nytamin.se>
@olzzon
Copy link
Author

olzzon commented May 16, 2024

This PR are merged into #7
So after approval changed should be merged into that, instead of release51

@Julusian Julusian changed the base branch from release51 to upstream-release51 September 19, 2024 09:53
@Julusian Julusian changed the title Feat/routeset config defined in blueprints Feat/routeset config defined in blueprints SOFIE-90 Sep 19, 2024
@olzzon olzzon requested a review from Julusian September 20, 2024 09:29
@Julusian Julusian changed the base branch from upstream-release51 to upstream/routeset-config-defined-in-blueprints September 23, 2024 14:23
@Julusian Julusian changed the title Feat/routeset config defined in blueprints SOFIE-90 feat: routeset config defined in blueprints SOFIE-90 Sep 23, 2024
@Julusian Julusian merged commit 85700c6 into upstream/routeset-config-defined-in-blueprints Sep 23, 2024
@Julusian
Copy link
Collaborator

Upstream PR Sofie-Automation#1262
I merged this PR to a branch for upstream, so that I could squash the changes prior to the PR

@Julusian Julusian deleted the feat/routeset-config-defined-in-blueprints branch October 21, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants