Skip to content

Conversation

@Julusian
Copy link
Member

@Julusian Julusian commented Sep 23, 2024

About the Contributor

This pull request is posted on behalf of the BBC

Type of Contribution

This is a: Feature

New Behavior

Routesets can now be setup by the blueprint studio applyConfig method.
They utilise the same ObjectWithOverrides structure as elsewhere.

The structure of these has not been to best make use of the ObjectWithOverrides workflow, making a change to a single route in the ui does cause all the routes to be marked as overridden.
This was not necessary for our use case, and requires some more indepth reworking of the types and structures.

Additionally, adlib-actions have a new method switchRouteSet which allows them to change the active state of a routeset.
The same operation has also been exposed to action-triggers.

Testing

  • I have added one or more unit tests for this PR
  • I have updated the relevant unit tests
  • No unit test changes are needed for this PR

Affected areas

This PR affects the playout logic in general.
This PR affects the routeset settings ui, and switchboard panel.
This PR affects the action triggers, adding a new operation.

Time Frame

Not urgent, but we would like to get this merged into the in-development release.

Other Information

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

@codecov
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 40.24896% with 144 lines in your changes missing coverage. Please review.

Project coverage is 60.63%. Comparing base (1d87ef1) to head (0bd2d4d).
Report is 35 commits behind head on release52.

Files with missing lines Patch % Lines
meteor/server/migration/X_X_X.ts 49.42% 44 Missing ⚠️
...ob-worker/src/studio/model/StudioBaselineHelper.ts 35.29% 43 Missing and 1 partial ⚠️
meteor/server/publications/studioUI.ts 0.00% 11 Missing ⚠️
meteor/server/migration/1_50_0.ts 40.00% 9 Missing ⚠️
...ons/packageManager/expectedPackages/publication.ts 0.00% 7 Missing ⚠️
meteor/server/api/playout/playout.ts 37.50% 5 Missing ⚠️
...ckages/corelib/src/settings/objectWithOverrides.ts 0.00% 4 Missing ⚠️
...r/api/deviceTriggers/StudioDeviceTriggerManager.ts 0.00% 3 Missing ⚠️
meteor/server/api/studio/api.ts 0.00% 3 Missing ⚠️
meteor/server/api/rest/v1/typeConversion.ts 0.00% 2 Missing ⚠️
... and 8 more
Additional details and impacted files
@@              Coverage Diff              @@
##           release52    #1262      +/-   ##
=============================================
- Coverage      60.68%   60.63%   -0.06%     
=============================================
  Files            459      458       -1     
  Lines          78126    78369     +243     
  Branches        3599     4945    +1346     
=============================================
+ Hits           47414    47517     +103     
- Misses         30516    30711     +195     
+ Partials         196      141      -55     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Julusian Julusian force-pushed the upstream/routeset-config-defined-in-blueprints branch from 4eb6431 to e839b97 Compare September 27, 2024 12:41
@mint-dewit mint-dewit added the Contribution from BBC Contributions sponsored by BBC (bbc.co.uk) label Sep 30, 2024
@nytamin
Copy link
Member

nytamin commented Oct 7, 2024

Looks good in general, but there a few details that would need to be addressed before merging.

@Julusian Julusian requested a review from nytamin October 8, 2024 12:09
@nytamin nytamin merged commit b6a7f90 into Sofie-Automation:release52 Oct 9, 2024
@Julusian Julusian deleted the upstream/routeset-config-defined-in-blueprints branch October 9, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Contribution from BBC Contributions sponsored by BBC (bbc.co.uk)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants