-
Notifications
You must be signed in to change notification settings - Fork 54
feat: routeset config defined in blueprints #1262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nytamin
merged 4 commits into
Sofie-Automation:release52
from
bbc:upstream/routeset-config-defined-in-blueprints
Oct 9, 2024
Merged
feat: routeset config defined in blueprints #1262
nytamin
merged 4 commits into
Sofie-Automation:release52
from
bbc:upstream/routeset-config-defined-in-blueprints
Oct 9, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release52 #1262 +/- ##
=============================================
- Coverage 60.68% 60.63% -0.06%
=============================================
Files 459 458 -1
Lines 78126 78369 +243
Branches 3599 4945 +1346
=============================================
+ Hits 47414 47517 +103
- Misses 30516 30711 +195
+ Partials 196 141 -55 ☔ View full report in Codecov by Sentry. |
8bd3c45 to
4eb6431
Compare
This was referenced Sep 23, 2024
4eb6431 to
e839b97
Compare
nytamin
requested changes
Oct 7, 2024
packages/webui/src/client/ui/Settings/ShowStyleBaseSettings.tsx
Outdated
Show resolved
Hide resolved
Member
|
Looks good in general, but there a few details that would need to be addressed before merging. |
nytamin
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the Contributor
This pull request is posted on behalf of the BBC
Type of Contribution
This is a: Feature
New Behavior
Routesets can now be setup by the blueprint studio
applyConfigmethod.They utilise the same
ObjectWithOverridesstructure as elsewhere.The structure of these has not been to best make use of the
ObjectWithOverridesworkflow, making a change to a single route in the ui does cause all the routes to be marked as overridden.This was not necessary for our use case, and requires some more indepth reworking of the types and structures.
Additionally, adlib-actions have a new method
switchRouteSetwhich allows them to change the active state of a routeset.The same operation has also been exposed to action-triggers.
Testing
Affected areas
This PR affects the playout logic in general.
This PR affects the routeset settings ui, and switchboard panel.
This PR affects the action triggers, adding a new operation.
Time Frame
Not urgent, but we would like to get this merged into the in-development release.
Other Information
Status