feat(EAV-663): allow blueprints to specify preview and thumbnail containter ids #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Can you explain why we need to do it this way. Is it core change . any documentation that corresponds to this . The reason being , i can see existing variable now move as subvars to another variable. So basically a schema change |
Collaborator
Author
|
Sofie-Automation#1263 will give you more context. Config defined by blueprints utilizes the overrides mechanism - blueprints provide the defaults, the user might override them. Overrides work on objects, hence the omnipresent ObjectWithOverrides. Since those two properties affected by this PR are very closely related, I placed them in the same object, which made it relatively simple. |
chandrashekar-nallamilli
approved these changes
Jul 17, 2025
Collaborator
chandrashekar-nallamilli
left a comment
chandrashekar-nallamilli
left a comment
There was a problem hiding this comment.
LGTM COde wise. But not completely sure of the functionality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.