Deprecate breadcrumbs and allow singular backAction prop on Page and Breadcrumbs #8135

itwasmattgregg · 2023-01-23T19:01:18Z

WHY are these changes introduced?

As a followup to #8016 in preparation for v11 where breadcrumb becomes singular (#7990).

I should have originally done this and deprecated breadcrumbs but at the time we had a different upgrade path in mind. After collaborating with a number of folks we determined deprecating breadcrumbs officially and moving to a singular breadcrumb in a backAction prop for v11 was the best path.

WHAT is this pull request doing?

How to 🎩

🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines

Copy-paste this code in playground/Playground.tsx:

import React from 'react';
import {Page} from '../src';

export function Playground() {
  return (
    <Page title="Playground">
      {/* Add the code you want to test in here */}
    </Page>
  );
}

🎩 checklist

Tested on mobile
Tested on multiple browsers
Tested for accessibility
Updated the component's README.md with documentation changes
Tophatted documentation changes in the style guide

github-actions · 2023-01-23T19:13:58Z

size-limit report 📦

Path	Size
polaris-react-cjs	220.21 KB (+0.03% 🔺)
polaris-react-esm	139.91 KB (+0.05% 🔺)
polaris-react-esnext	195.67 KB (+0.03% 🔺)
polaris-react-css	42.3 KB (0%)

alex-page · 2023-01-23T19:57:56Z

polaris-react/src/components/Breadcrumbs/Breadcrumbs.tsx

+  /** Breadcrumb link */
+  breadcrumb?: CallbackAction | LinkAction;


This will become required in v11?

Perhaps we should log a warning that the breadcrumb prop should "require" a value if no value is provided to either? A bit clunky but at least a temporary way to notify the developer until the next major update.

Added a warning

sam-b-rose

Nice update! Only had a few suggestions

sam-b-rose · 2023-01-23T20:13:44Z

polaris-react/src/components/Page/components/Header/Header.tsx

    console.warn(
      'Deprecation: The `additionalNavigation` on Page is deprecated and will be removed in the next major version.',
    );
+    // eslint-disable-next-line no-console


This should be wrapped in its own if statement when breadcrumbs is used:

if (breadcrumbs && process.env.NODE_ENV === 'development') { console.warn('...') }

Totally. Have no idea what I was thinking. Good catch

sam-b-rose · 2023-01-23T20:15:57Z

polaris-react/src/components/Breadcrumbs/Breadcrumbs.tsx

+  /** Breadcrumb link */
+  breadcrumb?: CallbackAction | LinkAction;


Perhaps we should log a warning that the breadcrumb prop should "require" a value if no value is provided to either? A bit clunky but at least a temporary way to notify the developer until the next major update.

sam-b-rose · 2023-01-23T20:26:12Z

polaris-react/src/components/Page/components/Header/Header.tsx

-        <Breadcrumbs breadcrumbs={breadcrumbs} />
-      </div>
-    ) : null;
+  const breadcrumbMarkup = () => {


Feels a bit odd to have this as a function since it relies on outside scope variables. I think we could keep breadcrumbMarkup a variable for simplicity:

let breadcrumbMarkup = null; if (breadcrumb) { breadcrumbMarkup = // value } else if (Array.isArray(...) ... ) { breadcrumbMarkup = // other value }

Ah yea I just tend avoid mutable code these days lol I forget it's even possible

alex-page

@itwasmattgregg before this ships can we change the name of breadcrumb to backAction. I am trying to align across the extensions team. See here:
https://github.com/Shopify/app-kit/discussions/150#discussioncomment-4994861

…Breadcrumbs

Linting

.changeset/metal-cows-poke.md

Co-authored-by: Chloe Rice <chloerice@users.noreply.github.com>

@chloerice

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/stylelint-polaris@8.0.0 ### Major Changes - [#8467](#8467) [`9ab93132a`](9ab9313) Thanks [@chloerice](https://github.com/chloerice)! - Configured `selector-disallowed-list` to disallow Polaris component class name overrides ### Patch Changes - Updated dependencies \[[`0e9fa8433`](0e9fa84), [`b1768f037`](b1768f0)]: - @shopify/polaris-tokens@6.6.1 ## @shopify/polaris-migrator@0.14.0 ### Minor Changes - [#8071](#8071) [`319479143`](3194791) Thanks [@itwasmattgregg](https://github.com/itwasmattgregg)! - Added a migration for updating the Page component `breadcrumbs` prop to use an object instead of an array ### Patch Changes - Updated dependencies \[[`0e9fa8433`](0e9fa84), [`9ab93132a`](9ab9313), [`b1768f037`](b1768f0)]: - @shopify/polaris-tokens@6.6.1 - @shopify/stylelint-polaris@8.0.0 ## @shopify/polaris@10.32.0 ### Minor Changes - [#8454](#8454) [`4799b6550`](4799b65) Thanks [@chazdean](https://github.com/chazdean)! - Removed default spacing from `Inline` - [#8484](#8484) [`cbbb5648c`](cbbb564) Thanks [@aveline](https://github.com/aveline)! - Removed default `gap` from `Columns` - [#8135](#8135) [`c60617518`](c606175) Thanks [@itwasmattgregg](https://github.com/itwasmattgregg)! - Deprecated the `Page` `breadcrumbs` prop in favor of the new `backAction` prop. - [#8441](#8441) [`3537b3aeb`](3537b3a) Thanks [@kyledurand](https://github.com/kyledurand)! - Deprecated TextContainer in favor of AlphaStack - [#8418](#8418) [`4018ee268`](4018ee2) Thanks [@kyledurand](https://github.com/kyledurand)! - Deprecated Grid component Update documentation for deprecated components - [#8413](#8413) [`7bbe096e4`](7bbe096) Thanks [@zakwarsame](https://github.com/zakwarsame)! - updating bulk actions strings ### Patch Changes - [#8387](#8387) [`7f0f2cad1`](7f0f2ca) Thanks [@aveline](https://github.com/aveline)! - Updated `Columns` to accept columns aliases - [#8115](#8115) [`cc706f4ce`](cc706f4) Thanks [@mrcthms](https://github.com/mrcthms)! - Grouped PageActions actions at the trailing edge of the container - [#8470](#8470) [`f5e450357`](f5e4503) Thanks [@aveline](https://github.com/aveline)! - Removed default margin from `Bleed` - Updated dependencies \[[`0e9fa8433`](0e9fa84), [`b1768f037`](b1768f0)]: - @shopify/polaris-tokens@6.6.1 ## @shopify/polaris-cli@0.1.13 ### Patch Changes - Updated dependencies \[[`319479143`](3194791)]: - @shopify/polaris-migrator@0.14.0 ## @shopify/polaris-tokens@6.6.1 ### Patch Changes - [#8456](#8456) [`0e9fa8433`](0e9fa84) Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Updated `border-caution-subdued` and `border-success-subdued` tokens to improve color contrast - [#8483](#8483) [`b1768f037`](b1768f0) Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Adjusted colors to meet color contrast requirements ## polaris.shopify.com@0.37.0 ### Minor Changes - [#8454](#8454) [`4799b6550`](4799b65) Thanks [@chazdean](https://github.com/chazdean)! - Removed default spacing from `Inline` - [#7843](#7843) [`3840f49e9`](3840f49) Thanks [@gwyneplaine](https://github.com/gwyneplaine)! - ## Reboot Pattern Guidance - New layout primitives `Stack`, `Box`, `Grid`, `Row`. - Playroom patched to support larger code snippets. - New designs and content for the [patterns](https://polaris.shopify.com/patterns) pages. - Deprecated old patterns: ||Old|New| \|--\|--\|--\| \|**design-patterns** \| `/patterns/design-patterns` \| `404`\| \|**page-layouts** \| `/patterns/page-layouts` \| `404`\| \|**error-messages** \| `/patterns/error-messages` \| `/content/error-messages`\| \|**help-content** \| `/patterns/help-content` \| `/content/help-content`\| \|**loading** \| `/patterns/loading` \| `/patterns-legacy/loading`\| \|**new-badge** \| `/patterns/new-badge` \| `/patterns-legacy/new-badge`\| \|**pickers** \| `/patterns/pickers` \| `/patterns-legacy/pickers`\| \|**text-fields** \| `/patterns/text-fields` \| `/patterns-legacy/text-fields`\| - Page padding and max-width adjusted such that live previews for components and patterns always display the desktop breakpoint. - [#8466](#8466) [`3b32f3477`](3b32f34) Thanks [@itwasmattgregg](https://github.com/itwasmattgregg)! - Adds documentation for the Page breadcrumbs migration ### Patch Changes - [#8475](#8475) [`ba7280068`](ba72800) Thanks [@chloerice](https://github.com/chloerice)! - Added documentation for `selector-disallowed-list` `@shopify/stylelint/polaris` rule - [#8474](#8474) [`00028952d`](0002895) Thanks [@jesstelford](https://github.com/jesstelford)! - Refactor hideFromNav logic to support breadcrumbs - [#8490](#8490) [`16f5a3638`](16f5a36) Thanks [@jesstelford](https://github.com/jesstelford)! - Add caveats to code examples in Patterns - [#8491](#8491) [`39704dccf`](39704dc) Thanks [@jesstelford](https://github.com/jesstelford)! - Add 'New' status badge to Patterns nav item - [#8422](#8422) [`3975668a2`](3975668) Thanks [@kyledurand](https://github.com/kyledurand)! - Organized categories on components page - [#8473](#8473) [`597b78ba2`](597b78b) Thanks [@gwyneplaine](https://github.com/gwyneplaine)! - Remove draft pattern pages from PatternsPage - [#8477](#8477) [`c67d1a5b6`](c67d1a5) Thanks [@kyledurand](https://github.com/kyledurand)! - Fix global types file - [#8418](#8418) [`4018ee268`](4018ee2) Thanks [@kyledurand](https://github.com/kyledurand)! - Deprecated Grid component Update documentation for deprecated components - [#8489](#8489) [`0a525643d`](0a52564) Thanks [@raquelbreternitz](https://github.com/raquelbreternitz)! - Add new page on alt text - [#8410](#8410) [`2312cbb6a`](2312cbb) Thanks [@kellydanma](https://github.com/kellydanma)! - Use Close instead of OK - Updated dependencies \[[`7f0f2cad1`](7f0f2ca), [`4799b6550`](4799b65), [`cbbb5648c`](cbbb564), [`c60617518`](c606175), [`cc706f4ce`](cc706f4), [`f5e450357`](f5e4503), [`3537b3aeb`](3537b3a), [`0e9fa8433`](0e9fa84), [`4018ee268`](4018ee2), [`7bbe096e4`](7bbe096), [`b1768f037`](b1768f0)]: - @shopify/polaris@10.32.0 - @shopify/polaris-tokens@6.6.1 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…Breadcrumbs (Shopify#8135) ### WHY are these changes introduced? As a followup to Shopify#8016 in preparation for v11 where breadcrumb becomes singular (Shopify#7990). I should have originally done this and deprecated breadcrumbs but at the time we had a different upgrade path in mind. After collaborating with a number of folks we determined deprecating breadcrumbs officially and moving to a singular breadcrumb in a `backAction` prop for v11 was the best path. ### WHAT is this pull request doing?   ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog)  <details> <summary>Copy-paste this code in <code>playground/Playground.tsx</code>:</summary> ```jsx import React from 'react'; import {Page} from '../src'; export function Playground() { return ( <Page title="Playground"> {/* Add the code you want to test in here */} </Page> ); } ``` </details> ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide --------- Co-authored-by: Chloe Rice <chloerice@users.noreply.github.com>

@chloerice

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/stylelint-polaris@8.0.0 ### Major Changes - [Shopify#8467](Shopify#8467) [`9ab93132a`](Shopify@9ab9313) Thanks [@chloerice](https://github.com/chloerice)! - Configured `selector-disallowed-list` to disallow Polaris component class name overrides ### Patch Changes - Updated dependencies \[[`0e9fa8433`](Shopify@0e9fa84), [`b1768f037`](Shopify@b1768f0)]: - @shopify/polaris-tokens@6.6.1 ## @shopify/polaris-migrator@0.14.0 ### Minor Changes - [Shopify#8071](Shopify#8071) [`319479143`](Shopify@3194791) Thanks [@itwasmattgregg](https://github.com/itwasmattgregg)! - Added a migration for updating the Page component `breadcrumbs` prop to use an object instead of an array ### Patch Changes - Updated dependencies \[[`0e9fa8433`](Shopify@0e9fa84), [`9ab93132a`](Shopify@9ab9313), [`b1768f037`](Shopify@b1768f0)]: - @shopify/polaris-tokens@6.6.1 - @shopify/stylelint-polaris@8.0.0 ## @shopify/polaris@10.32.0 ### Minor Changes - [Shopify#8454](Shopify#8454) [`4799b6550`](Shopify@4799b65) Thanks [@chazdean](https://github.com/chazdean)! - Removed default spacing from `Inline` - [Shopify#8484](Shopify#8484) [`cbbb5648c`](Shopify@cbbb564) Thanks [@aveline](https://github.com/aveline)! - Removed default `gap` from `Columns` - [Shopify#8135](Shopify#8135) [`c60617518`](Shopify@c606175) Thanks [@itwasmattgregg](https://github.com/itwasmattgregg)! - Deprecated the `Page` `breadcrumbs` prop in favor of the new `backAction` prop. - [Shopify#8441](Shopify#8441) [`3537b3aeb`](Shopify@3537b3a) Thanks [@kyledurand](https://github.com/kyledurand)! - Deprecated TextContainer in favor of AlphaStack - [Shopify#8418](Shopify#8418) [`4018ee268`](Shopify@4018ee2) Thanks [@kyledurand](https://github.com/kyledurand)! - Deprecated Grid component Update documentation for deprecated components - [Shopify#8413](Shopify#8413) [`7bbe096e4`](Shopify@7bbe096) Thanks [@zakwarsame](https://github.com/zakwarsame)! - updating bulk actions strings ### Patch Changes - [Shopify#8387](Shopify#8387) [`7f0f2cad1`](Shopify@7f0f2ca) Thanks [@aveline](https://github.com/aveline)! - Updated `Columns` to accept columns aliases - [Shopify#8115](Shopify#8115) [`cc706f4ce`](Shopify@cc706f4) Thanks [@mrcthms](https://github.com/mrcthms)! - Grouped PageActions actions at the trailing edge of the container - [Shopify#8470](Shopify#8470) [`f5e450357`](Shopify@f5e4503) Thanks [@aveline](https://github.com/aveline)! - Removed default margin from `Bleed` - Updated dependencies \[[`0e9fa8433`](Shopify@0e9fa84), [`b1768f037`](Shopify@b1768f0)]: - @shopify/polaris-tokens@6.6.1 ## @shopify/polaris-cli@0.1.13 ### Patch Changes - Updated dependencies \[[`319479143`](Shopify@3194791)]: - @shopify/polaris-migrator@0.14.0 ## @shopify/polaris-tokens@6.6.1 ### Patch Changes - [Shopify#8456](Shopify#8456) [`0e9fa8433`](Shopify@0e9fa84) Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Updated `border-caution-subdued` and `border-success-subdued` tokens to improve color contrast - [Shopify#8483](Shopify#8483) [`b1768f037`](Shopify@b1768f0) Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Adjusted colors to meet color contrast requirements ## polaris.shopify.com@0.37.0 ### Minor Changes - [Shopify#8454](Shopify#8454) [`4799b6550`](Shopify@4799b65) Thanks [@chazdean](https://github.com/chazdean)! - Removed default spacing from `Inline` - [Shopify#7843](Shopify#7843) [`3840f49e9`](Shopify@3840f49) Thanks [@gwyneplaine](https://github.com/gwyneplaine)! - ## Reboot Pattern Guidance - New layout primitives `Stack`, `Box`, `Grid`, `Row`. - Playroom patched to support larger code snippets. - New designs and content for the [patterns](https://polaris.shopify.com/patterns) pages. - Deprecated old patterns: ||Old|New| \|--\|--\|--\| \|**design-patterns** \| `/patterns/design-patterns` \| `404`\| \|**page-layouts** \| `/patterns/page-layouts` \| `404`\| \|**error-messages** \| `/patterns/error-messages` \| `/content/error-messages`\| \|**help-content** \| `/patterns/help-content` \| `/content/help-content`\| \|**loading** \| `/patterns/loading` \| `/patterns-legacy/loading`\| \|**new-badge** \| `/patterns/new-badge` \| `/patterns-legacy/new-badge`\| \|**pickers** \| `/patterns/pickers` \| `/patterns-legacy/pickers`\| \|**text-fields** \| `/patterns/text-fields` \| `/patterns-legacy/text-fields`\| - Page padding and max-width adjusted such that live previews for components and patterns always display the desktop breakpoint. - [Shopify#8466](Shopify#8466) [`3b32f3477`](Shopify@3b32f34) Thanks [@itwasmattgregg](https://github.com/itwasmattgregg)! - Adds documentation for the Page breadcrumbs migration ### Patch Changes - [Shopify#8475](Shopify#8475) [`ba7280068`](Shopify@ba72800) Thanks [@chloerice](https://github.com/chloerice)! - Added documentation for `selector-disallowed-list` `@shopify/stylelint/polaris` rule - [Shopify#8474](Shopify#8474) [`00028952d`](Shopify@0002895) Thanks [@jesstelford](https://github.com/jesstelford)! - Refactor hideFromNav logic to support breadcrumbs - [Shopify#8490](Shopify#8490) [`16f5a3638`](Shopify@16f5a36) Thanks [@jesstelford](https://github.com/jesstelford)! - Add caveats to code examples in Patterns - [Shopify#8491](Shopify#8491) [`39704dccf`](Shopify@39704dc) Thanks [@jesstelford](https://github.com/jesstelford)! - Add 'New' status badge to Patterns nav item - [Shopify#8422](Shopify#8422) [`3975668a2`](Shopify@3975668) Thanks [@kyledurand](https://github.com/kyledurand)! - Organized categories on components page - [Shopify#8473](Shopify#8473) [`597b78ba2`](Shopify@597b78b) Thanks [@gwyneplaine](https://github.com/gwyneplaine)! - Remove draft pattern pages from PatternsPage - [Shopify#8477](Shopify#8477) [`c67d1a5b6`](Shopify@c67d1a5) Thanks [@kyledurand](https://github.com/kyledurand)! - Fix global types file - [Shopify#8418](Shopify#8418) [`4018ee268`](Shopify@4018ee2) Thanks [@kyledurand](https://github.com/kyledurand)! - Deprecated Grid component Update documentation for deprecated components - [Shopify#8489](Shopify#8489) [`0a525643d`](Shopify@0a52564) Thanks [@raquelbreternitz](https://github.com/raquelbreternitz)! - Add new page on alt text - [Shopify#8410](Shopify#8410) [`2312cbb6a`](Shopify@2312cbb) Thanks [@kellydanma](https://github.com/kellydanma)! - Use Close instead of OK - Updated dependencies \[[`7f0f2cad1`](Shopify@7f0f2ca), [`4799b6550`](Shopify@4799b65), [`cbbb5648c`](Shopify@cbbb564), [`c60617518`](Shopify@c606175), [`cc706f4ce`](Shopify@cc706f4), [`f5e450357`](Shopify@f5e4503), [`3537b3aeb`](Shopify@3537b3a), [`0e9fa8433`](Shopify@0e9fa84), [`4018ee268`](Shopify@4018ee2), [`7bbe096e4`](Shopify@7bbe096), [`b1768f037`](Shopify@b1768f0)]: - @shopify/polaris@10.32.0 - @shopify/polaris-tokens@6.6.1 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

itwasmattgregg mentioned this pull request Jan 23, 2023

Breadcrumb migrator #8071

Merged

5 tasks

itwasmattgregg requested review from alex-page, kyledurand, sam-b-rose and tmlayton January 23, 2023 19:20

itwasmattgregg self-assigned this Jan 23, 2023

alex-page reviewed Jan 23, 2023

View reviewed changes

itwasmattgregg requested a review from alex-page January 23, 2023 20:19

sam-b-rose reviewed Jan 23, 2023

View reviewed changes

alex-page requested changes Feb 19, 2023

View reviewed changes

alex-page added the v11.0.0 label Feb 19, 2023

itwasmattgregg requested review from alex-page and sam-b-rose February 22, 2023 17:46

itwasmattgregg added 2 commits February 22, 2023 11:56

Deprecate breadcrumbs and allow singular breadcrumb prop on Page and …

256f863

…Breadcrumbs

Adds changeset

c5f6332

itwasmattgregg force-pushed the deprecate-breadcrumbs branch from 2155446 to 16725ef Compare February 22, 2023 17:58

itwasmattgregg added 3 commits February 22, 2023 14:23

change breadcrumb to backAction

9cf7b8d

Linting

Add requirement warning

60c8274

Refactor breadcrumbMarkup variable

3a1981c

itwasmattgregg force-pushed the deprecate-breadcrumbs branch from a0be119 to 3a1981c Compare February 22, 2023 20:23

itwasmattgregg changed the title ~~Deprecate breadcrumbs and allow singular breadcrumb prop on Page and Breadcrumbs~~ Deprecate breadcrumbs and allow singular backAction prop on Page and Breadcrumbs Feb 22, 2023

alex-page approved these changes Feb 22, 2023

View reviewed changes

itwasmattgregg added 2 commits February 22, 2023 15:15

Add backAction check to Page

0e32b2b

Fix breacrumb markup assignment

426ab59

chloerice approved these changes Feb 23, 2023

View reviewed changes

.changeset/metal-cows-poke.md Outdated Show resolved Hide resolved

Update .changeset/metal-cows-poke.md

f71ddb3

Co-authored-by: Chloe Rice <chloerice@users.noreply.github.com>

itwasmattgregg merged commit c606175 into main Feb 23, 2023

itwasmattgregg deleted the deprecate-breadcrumbs branch February 23, 2023 01:42

shopify-github-actions-access bot mentioned this pull request Feb 23, 2023

Version Packages #8453

Merged

		/** Breadcrumb link */
		breadcrumb?: CallbackAction \| LinkAction;

Deprecate breadcrumbs and allow singular backAction prop on Page and Breadcrumbs #8135

Deprecate breadcrumbs and allow singular backAction prop on Page and Breadcrumbs #8135

Uh oh!

Conversation

itwasmattgregg commented Jan 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

WHY are these changes introduced?

WHAT is this pull request doing?

How to 🎩

🎩 checklist

Uh oh!

github-actions bot commented Jan 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sam-b-rose left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alex-page left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

itwasmattgregg commented Jan 23, 2023 •

edited

Loading

github-actions bot commented Jan 23, 2023 •

edited

Loading