Skip to content

Commit 3a1981c

Browse files
Refactor breadcrumbMarkup variable
1 parent 60c8274 commit 3a1981c

File tree

1 file changed

+23
-26
lines changed
  • polaris-react/src/components/Page/components/Header

1 file changed

+23
-26
lines changed

polaris-react/src/components/Page/components/Header/Header.tsx

Lines changed: 23 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -108,32 +108,29 @@ export function Header({
108108
isReactElement(secondaryActions)) &&
109109
!actionGroups.length;
110110

111-
const breadcrumbMarkup = () => {
112-
if (backAction) {
113-
return (
114-
<div className={styles.BreadcrumbWrapper}>
115-
<Box maxWidth="100%" paddingInlineEnd="4" printHidden>
116-
<Breadcrumbs backAction={backAction} />
117-
</Box>
118-
</div>
119-
);
120-
}
121-
122-
if (
123-
(Array.isArray(breadcrumbs) && breadcrumbs.length > 0) ||
124-
(!Array.isArray(breadcrumbs) && breadcrumbs)
125-
) {
126-
return (
127-
<div className={styles.BreadcrumbWrapper}>
128-
<Box maxWidth="100%" paddingInlineEnd="4" printHidden>
129-
<Breadcrumbs breadcrumbs={breadcrumbs} />
130-
</Box>
131-
</div>
132-
);
133-
}
134-
111+
let breadcrumbMarkup = null;
112+
if (backAction) {
113+
breadcrumbMarkup = (
114+
<div className={styles.BreadcrumbWrapper}>
115+
<Box maxWidth="100%" paddingInlineEnd="4" printHidden>
116+
<Breadcrumbs backAction={backAction} />
117+
</Box>
118+
</div>
119+
);
120+
} else if (
121+
(Array.isArray(breadcrumbs) && breadcrumbs.length > 0) ||
122+
(!Array.isArray(breadcrumbs) && breadcrumbs)
123+
) {
124+
return (
125+
<div className={styles.BreadcrumbWrapper}>
126+
<Box maxWidth="100%" paddingInlineEnd="4" printHidden>
127+
<Breadcrumbs breadcrumbs={breadcrumbs} />
128+
</Box>
129+
</div>
130+
);
131+
} else {
135132
return null;
136-
};
133+
}
137134

138135
const paginationMarkup =
139136
pagination && !isNavigationCollapsed ? (
@@ -352,7 +349,7 @@ function determineLayout({
352349
actionMenuMarkup: MaybeJSX;
353350
additionalMetadataMarkup: MaybeJSX;
354351
additionalNavigationMarkup: MaybeJSX;
355-
breadcrumbMarkup: () => MaybeJSX;
352+
breadcrumbMarkup: MaybeJSX;
356353
isNavigationCollapsed: boolean;
357354
pageTitleMarkup: JSX.Element;
358355
paginationMarkup: MaybeJSX;

0 commit comments

Comments
 (0)