[Layout foundations] Deprecate TextContainer #8441

kyledurand · 2023-02-21T17:24:40Z

Closes: #7404

github-actions · 2023-02-21T17:42:59Z

size-limit report 📦

Path	Size
polaris-react-cjs	220.29 KB (-0.02% 🔽)
polaris-react-esm	140.04 KB (-0.01% 🔽)
polaris-react-esnext	195.87 KB (-0.01% 🔽)
polaris-react-css	42.38 KB (0%)

aveline · 2023-02-21T18:06:46Z

polaris-react/src/components/CalloutCard/CalloutCard.tsx

 import type {Action} from '../../types';
 import {Card} from '../Card';
+// eslint-disable-next-line import/no-deprecated
 import {TextContainer} from '../TextContainer';


Should this get replaced by AlphaStack? Or will that happen in another PR?

That will happen in the migration PR which @yurm04 is working on

laurkim

💯
Probably need to update URL for redirects

laurkim · 2023-02-22T13:33:20Z

polaris.shopify.com/content/components/deprecated/text-container.md

  - margin
  - padding
+status:
+  value: Deprecated


category should also be updated to deprecated

kyledurand · 2023-02-22T21:34:18Z

/snapit

github-actions · 2023-02-22T21:38:30Z

🫰✨ Thanks @kyledurand! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @shopify/polaris-cli@0.0.0-snapshot-release-20230222213642

yarn add @shopify/polaris@0.0.0-snapshot-release-20230222213642

@chloerice

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/stylelint-polaris@8.0.0 ### Major Changes - [#8467](#8467) [`9ab93132a`](9ab9313) Thanks [@chloerice](https://github.com/chloerice)! - Configured `selector-disallowed-list` to disallow Polaris component class name overrides ### Patch Changes - Updated dependencies \[[`0e9fa8433`](0e9fa84), [`b1768f037`](b1768f0)]: - @shopify/polaris-tokens@6.6.1 ## @shopify/polaris-migrator@0.14.0 ### Minor Changes - [#8071](#8071) [`319479143`](3194791) Thanks [@itwasmattgregg](https://github.com/itwasmattgregg)! - Added a migration for updating the Page component `breadcrumbs` prop to use an object instead of an array ### Patch Changes - Updated dependencies \[[`0e9fa8433`](0e9fa84), [`9ab93132a`](9ab9313), [`b1768f037`](b1768f0)]: - @shopify/polaris-tokens@6.6.1 - @shopify/stylelint-polaris@8.0.0 ## @shopify/polaris@10.32.0 ### Minor Changes - [#8454](#8454) [`4799b6550`](4799b65) Thanks [@chazdean](https://github.com/chazdean)! - Removed default spacing from `Inline` - [#8484](#8484) [`cbbb5648c`](cbbb564) Thanks [@aveline](https://github.com/aveline)! - Removed default `gap` from `Columns` - [#8135](#8135) [`c60617518`](c606175) Thanks [@itwasmattgregg](https://github.com/itwasmattgregg)! - Deprecated the `Page` `breadcrumbs` prop in favor of the new `backAction` prop. - [#8441](#8441) [`3537b3aeb`](3537b3a) Thanks [@kyledurand](https://github.com/kyledurand)! - Deprecated TextContainer in favor of AlphaStack - [#8418](#8418) [`4018ee268`](4018ee2) Thanks [@kyledurand](https://github.com/kyledurand)! - Deprecated Grid component Update documentation for deprecated components - [#8413](#8413) [`7bbe096e4`](7bbe096) Thanks [@zakwarsame](https://github.com/zakwarsame)! - updating bulk actions strings ### Patch Changes - [#8387](#8387) [`7f0f2cad1`](7f0f2ca) Thanks [@aveline](https://github.com/aveline)! - Updated `Columns` to accept columns aliases - [#8115](#8115) [`cc706f4ce`](cc706f4) Thanks [@mrcthms](https://github.com/mrcthms)! - Grouped PageActions actions at the trailing edge of the container - [#8470](#8470) [`f5e450357`](f5e4503) Thanks [@aveline](https://github.com/aveline)! - Removed default margin from `Bleed` - Updated dependencies \[[`0e9fa8433`](0e9fa84), [`b1768f037`](b1768f0)]: - @shopify/polaris-tokens@6.6.1 ## @shopify/polaris-cli@0.1.13 ### Patch Changes - Updated dependencies \[[`319479143`](3194791)]: - @shopify/polaris-migrator@0.14.0 ## @shopify/polaris-tokens@6.6.1 ### Patch Changes - [#8456](#8456) [`0e9fa8433`](0e9fa84) Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Updated `border-caution-subdued` and `border-success-subdued` tokens to improve color contrast - [#8483](#8483) [`b1768f037`](b1768f0) Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Adjusted colors to meet color contrast requirements ## polaris.shopify.com@0.37.0 ### Minor Changes - [#8454](#8454) [`4799b6550`](4799b65) Thanks [@chazdean](https://github.com/chazdean)! - Removed default spacing from `Inline` - [#7843](#7843) [`3840f49e9`](3840f49) Thanks [@gwyneplaine](https://github.com/gwyneplaine)! - ## Reboot Pattern Guidance - New layout primitives `Stack`, `Box`, `Grid`, `Row`. - Playroom patched to support larger code snippets. - New designs and content for the [patterns](https://polaris.shopify.com/patterns) pages. - Deprecated old patterns: ||Old|New| \|--\|--\|--\| \|**design-patterns** \| `/patterns/design-patterns` \| `404`\| \|**page-layouts** \| `/patterns/page-layouts` \| `404`\| \|**error-messages** \| `/patterns/error-messages` \| `/content/error-messages`\| \|**help-content** \| `/patterns/help-content` \| `/content/help-content`\| \|**loading** \| `/patterns/loading` \| `/patterns-legacy/loading`\| \|**new-badge** \| `/patterns/new-badge` \| `/patterns-legacy/new-badge`\| \|**pickers** \| `/patterns/pickers` \| `/patterns-legacy/pickers`\| \|**text-fields** \| `/patterns/text-fields` \| `/patterns-legacy/text-fields`\| - Page padding and max-width adjusted such that live previews for components and patterns always display the desktop breakpoint. - [#8466](#8466) [`3b32f3477`](3b32f34) Thanks [@itwasmattgregg](https://github.com/itwasmattgregg)! - Adds documentation for the Page breadcrumbs migration ### Patch Changes - [#8475](#8475) [`ba7280068`](ba72800) Thanks [@chloerice](https://github.com/chloerice)! - Added documentation for `selector-disallowed-list` `@shopify/stylelint/polaris` rule - [#8474](#8474) [`00028952d`](0002895) Thanks [@jesstelford](https://github.com/jesstelford)! - Refactor hideFromNav logic to support breadcrumbs - [#8490](#8490) [`16f5a3638`](16f5a36) Thanks [@jesstelford](https://github.com/jesstelford)! - Add caveats to code examples in Patterns - [#8491](#8491) [`39704dccf`](39704dc) Thanks [@jesstelford](https://github.com/jesstelford)! - Add 'New' status badge to Patterns nav item - [#8422](#8422) [`3975668a2`](3975668) Thanks [@kyledurand](https://github.com/kyledurand)! - Organized categories on components page - [#8473](#8473) [`597b78ba2`](597b78b) Thanks [@gwyneplaine](https://github.com/gwyneplaine)! - Remove draft pattern pages from PatternsPage - [#8477](#8477) [`c67d1a5b6`](c67d1a5) Thanks [@kyledurand](https://github.com/kyledurand)! - Fix global types file - [#8418](#8418) [`4018ee268`](4018ee2) Thanks [@kyledurand](https://github.com/kyledurand)! - Deprecated Grid component Update documentation for deprecated components - [#8489](#8489) [`0a525643d`](0a52564) Thanks [@raquelbreternitz](https://github.com/raquelbreternitz)! - Add new page on alt text - [#8410](#8410) [`2312cbb6a`](2312cbb) Thanks [@kellydanma](https://github.com/kellydanma)! - Use Close instead of OK - Updated dependencies \[[`7f0f2cad1`](7f0f2ca), [`4799b6550`](4799b65), [`cbbb5648c`](cbbb564), [`c60617518`](c606175), [`cc706f4ce`](cc706f4), [`f5e450357`](f5e4503), [`3537b3aeb`](3537b3a), [`0e9fa8433`](0e9fa84), [`4018ee268`](4018ee2), [`7bbe096e4`](7bbe096), [`b1768f037`](b1768f0)]: - @shopify/polaris@10.32.0 - @shopify/polaris-tokens@6.6.1 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Closes: Shopify#7404

@chloerice

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/stylelint-polaris@8.0.0 ### Major Changes - [Shopify#8467](Shopify#8467) [`9ab93132a`](Shopify@9ab9313) Thanks [@chloerice](https://github.com/chloerice)! - Configured `selector-disallowed-list` to disallow Polaris component class name overrides ### Patch Changes - Updated dependencies \[[`0e9fa8433`](Shopify@0e9fa84), [`b1768f037`](Shopify@b1768f0)]: - @shopify/polaris-tokens@6.6.1 ## @shopify/polaris-migrator@0.14.0 ### Minor Changes - [Shopify#8071](Shopify#8071) [`319479143`](Shopify@3194791) Thanks [@itwasmattgregg](https://github.com/itwasmattgregg)! - Added a migration for updating the Page component `breadcrumbs` prop to use an object instead of an array ### Patch Changes - Updated dependencies \[[`0e9fa8433`](Shopify@0e9fa84), [`9ab93132a`](Shopify@9ab9313), [`b1768f037`](Shopify@b1768f0)]: - @shopify/polaris-tokens@6.6.1 - @shopify/stylelint-polaris@8.0.0 ## @shopify/polaris@10.32.0 ### Minor Changes - [Shopify#8454](Shopify#8454) [`4799b6550`](Shopify@4799b65) Thanks [@chazdean](https://github.com/chazdean)! - Removed default spacing from `Inline` - [Shopify#8484](Shopify#8484) [`cbbb5648c`](Shopify@cbbb564) Thanks [@aveline](https://github.com/aveline)! - Removed default `gap` from `Columns` - [Shopify#8135](Shopify#8135) [`c60617518`](Shopify@c606175) Thanks [@itwasmattgregg](https://github.com/itwasmattgregg)! - Deprecated the `Page` `breadcrumbs` prop in favor of the new `backAction` prop. - [Shopify#8441](Shopify#8441) [`3537b3aeb`](Shopify@3537b3a) Thanks [@kyledurand](https://github.com/kyledurand)! - Deprecated TextContainer in favor of AlphaStack - [Shopify#8418](Shopify#8418) [`4018ee268`](Shopify@4018ee2) Thanks [@kyledurand](https://github.com/kyledurand)! - Deprecated Grid component Update documentation for deprecated components - [Shopify#8413](Shopify#8413) [`7bbe096e4`](Shopify@7bbe096) Thanks [@zakwarsame](https://github.com/zakwarsame)! - updating bulk actions strings ### Patch Changes - [Shopify#8387](Shopify#8387) [`7f0f2cad1`](Shopify@7f0f2ca) Thanks [@aveline](https://github.com/aveline)! - Updated `Columns` to accept columns aliases - [Shopify#8115](Shopify#8115) [`cc706f4ce`](Shopify@cc706f4) Thanks [@mrcthms](https://github.com/mrcthms)! - Grouped PageActions actions at the trailing edge of the container - [Shopify#8470](Shopify#8470) [`f5e450357`](Shopify@f5e4503) Thanks [@aveline](https://github.com/aveline)! - Removed default margin from `Bleed` - Updated dependencies \[[`0e9fa8433`](Shopify@0e9fa84), [`b1768f037`](Shopify@b1768f0)]: - @shopify/polaris-tokens@6.6.1 ## @shopify/polaris-cli@0.1.13 ### Patch Changes - Updated dependencies \[[`319479143`](Shopify@3194791)]: - @shopify/polaris-migrator@0.14.0 ## @shopify/polaris-tokens@6.6.1 ### Patch Changes - [Shopify#8456](Shopify#8456) [`0e9fa8433`](Shopify@0e9fa84) Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Updated `border-caution-subdued` and `border-success-subdued` tokens to improve color contrast - [Shopify#8483](Shopify#8483) [`b1768f037`](Shopify@b1768f0) Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Adjusted colors to meet color contrast requirements ## polaris.shopify.com@0.37.0 ### Minor Changes - [Shopify#8454](Shopify#8454) [`4799b6550`](Shopify@4799b65) Thanks [@chazdean](https://github.com/chazdean)! - Removed default spacing from `Inline` - [Shopify#7843](Shopify#7843) [`3840f49e9`](Shopify@3840f49) Thanks [@gwyneplaine](https://github.com/gwyneplaine)! - ## Reboot Pattern Guidance - New layout primitives `Stack`, `Box`, `Grid`, `Row`. - Playroom patched to support larger code snippets. - New designs and content for the [patterns](https://polaris.shopify.com/patterns) pages. - Deprecated old patterns: ||Old|New| \|--\|--\|--\| \|**design-patterns** \| `/patterns/design-patterns` \| `404`\| \|**page-layouts** \| `/patterns/page-layouts` \| `404`\| \|**error-messages** \| `/patterns/error-messages` \| `/content/error-messages`\| \|**help-content** \| `/patterns/help-content` \| `/content/help-content`\| \|**loading** \| `/patterns/loading` \| `/patterns-legacy/loading`\| \|**new-badge** \| `/patterns/new-badge` \| `/patterns-legacy/new-badge`\| \|**pickers** \| `/patterns/pickers` \| `/patterns-legacy/pickers`\| \|**text-fields** \| `/patterns/text-fields` \| `/patterns-legacy/text-fields`\| - Page padding and max-width adjusted such that live previews for components and patterns always display the desktop breakpoint. - [Shopify#8466](Shopify#8466) [`3b32f3477`](Shopify@3b32f34) Thanks [@itwasmattgregg](https://github.com/itwasmattgregg)! - Adds documentation for the Page breadcrumbs migration ### Patch Changes - [Shopify#8475](Shopify#8475) [`ba7280068`](Shopify@ba72800) Thanks [@chloerice](https://github.com/chloerice)! - Added documentation for `selector-disallowed-list` `@shopify/stylelint/polaris` rule - [Shopify#8474](Shopify#8474) [`00028952d`](Shopify@0002895) Thanks [@jesstelford](https://github.com/jesstelford)! - Refactor hideFromNav logic to support breadcrumbs - [Shopify#8490](Shopify#8490) [`16f5a3638`](Shopify@16f5a36) Thanks [@jesstelford](https://github.com/jesstelford)! - Add caveats to code examples in Patterns - [Shopify#8491](Shopify#8491) [`39704dccf`](Shopify@39704dc) Thanks [@jesstelford](https://github.com/jesstelford)! - Add 'New' status badge to Patterns nav item - [Shopify#8422](Shopify#8422) [`3975668a2`](Shopify@3975668) Thanks [@kyledurand](https://github.com/kyledurand)! - Organized categories on components page - [Shopify#8473](Shopify#8473) [`597b78ba2`](Shopify@597b78b) Thanks [@gwyneplaine](https://github.com/gwyneplaine)! - Remove draft pattern pages from PatternsPage - [Shopify#8477](Shopify#8477) [`c67d1a5b6`](Shopify@c67d1a5) Thanks [@kyledurand](https://github.com/kyledurand)! - Fix global types file - [Shopify#8418](Shopify#8418) [`4018ee268`](Shopify@4018ee2) Thanks [@kyledurand](https://github.com/kyledurand)! - Deprecated Grid component Update documentation for deprecated components - [Shopify#8489](Shopify#8489) [`0a525643d`](Shopify@0a52564) Thanks [@raquelbreternitz](https://github.com/raquelbreternitz)! - Add new page on alt text - [Shopify#8410](Shopify#8410) [`2312cbb6a`](Shopify@2312cbb) Thanks [@kellydanma](https://github.com/kellydanma)! - Use Close instead of OK - Updated dependencies \[[`7f0f2cad1`](Shopify@7f0f2ca), [`4799b6550`](Shopify@4799b65), [`cbbb5648c`](Shopify@cbbb564), [`c60617518`](Shopify@c606175), [`cc706f4ce`](Shopify@cc706f4), [`f5e450357`](Shopify@f5e4503), [`3537b3aeb`](Shopify@3537b3a), [`0e9fa8433`](Shopify@0e9fa84), [`4018ee268`](Shopify@4018ee2), [`7bbe096e4`](Shopify@7bbe096), [`b1768f037`](Shopify@b1768f0)]: - @shopify/polaris@10.32.0 - @shopify/polaris-tokens@6.6.1 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

kyledurand added the #gsd:30116 label Feb 21, 2023

kyledurand requested review from aveline, laurkim and yurm04 February 21, 2023 17:24

kyledurand self-assigned this Feb 21, 2023

kyledurand force-pushed the deprecate-text-container branch from 0e1acd3 to ac27d6d Compare February 21, 2023 17:58

aveline approved these changes Feb 21, 2023

View reviewed changes

kyledurand force-pushed the deprecate-text-container branch from ac27d6d to 83e75f3 Compare February 21, 2023 18:32

laurkim approved these changes Feb 22, 2023

View reviewed changes

laurkim reviewed Feb 22, 2023

View reviewed changes

kyledurand force-pushed the deprecate-text-container branch from 56f6f8f to 570ef5f Compare February 22, 2023 17:05

kyledurand force-pushed the deprecate-text-container branch 7 times, most recently from f91d06a to abb4cae Compare February 23, 2023 19:42

kyledurand added 4 commits February 23, 2023 15:04

chore: deprecate TextContainer

d0779b6

Fix lint

b131179

Change category and redirect

397cdfd

Rebase props.json

92aa741

kyledurand force-pushed the deprecate-text-container branch from abb4cae to 92aa741 Compare February 23, 2023 20:10

kyledurand merged commit 3537b3a into main Feb 23, 2023

kyledurand deleted the deprecate-text-container branch February 23, 2023 20:33

shopify-github-actions-access bot mentioned this pull request Feb 23, 2023

Version Packages #8453

Merged

juzser pushed a commit to juzser/polaris that referenced this pull request Jul 27, 2023

[Layout foundations] Deprecate TextContainer (Shopify#8441)

c9243ef

Closes: Shopify#7404

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Layout foundations] Deprecate TextContainer #8441

[Layout foundations] Deprecate TextContainer #8441

Uh oh!

kyledurand commented Feb 21, 2023

Uh oh!

github-actions bot commented Feb 21, 2023 •

edited

Loading

Uh oh!

aveline Feb 21, 2023

Uh oh!

kyledurand Feb 21, 2023

Uh oh!

laurkim left a comment •

edited

Loading

Uh oh!

laurkim Feb 22, 2023

Uh oh!

kyledurand commented Feb 22, 2023

Uh oh!

github-actions bot commented Feb 22, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[Layout foundations] Deprecate TextContainer #8441

[Layout foundations] Deprecate TextContainer #8441

Uh oh!

Conversation

kyledurand commented Feb 21, 2023

Uh oh!

github-actions bot commented Feb 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

aveline Feb 21, 2023

Choose a reason for hiding this comment

Uh oh!

kyledurand Feb 21, 2023

Choose a reason for hiding this comment

Uh oh!

laurkim left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

laurkim Feb 22, 2023

Choose a reason for hiding this comment

Uh oh!

kyledurand commented Feb 22, 2023

Uh oh!

github-actions bot commented Feb 22, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Feb 21, 2023 •

edited

Loading

laurkim left a comment •

edited

Loading