Fix responsive props #7903
Closed
Fix responsive props #7903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #7341 <!-- link to issue if one exists -->
Fixes #7358 Refactors `Banner` component to use new layout primitive components
Resolves #7340. Refactors `Modal` and its child components to use our layout primitives. [Storybook URL](https://5d559397bae39100201eedc1-nrruulmwsh.chromatic.com/?path=/story/all-components-modal--default). Refactors `Modal`, `Modal.Section`, `Modal.Header`, and `Modal.Footer` to use our layout primitives and remove css. [Storybook URL](https://5d559397bae39100201eedc1-nrruulmwsh.chromatic.com/?path=/story/all-components-modal--default). I've tophatted all of our stories as well as the UI for all of our breakpoints. 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [x] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
I'm still of the opinion that our layout components should have some defaults and the ones we have on bleed may not be right but we need to use it in more places to figure out what those defaults should be. For now, this fixes regressions to Banner that were introduced in #7644
Resolves #7354 - Refactored `ChoiceList` to use primitive Layout components - Added support for `legend` element to `Box` - Add support for `fieldset` element to `AlphaStack` There should be no visual changes. Co-authored-by: Lo Kim <lo.kim@shopify.com> Co-authored-by: Kyle Durand <kyledurand@users.noreply.github.com>
### WHY are these changes introduced? Quick cleanup of Account Connection
Contributor
size-limit report 📦
|
Co-authored-by: Kyle Durand <kyle.durand@shopify.com>
kyledurand
added a commit
that referenced
this pull request
Dec 14, 2022
Fixes nested Boxes spacing issues in Safari and Chromatic 🎩 changes on the layout beta branch [here](#7903) I think there are still improvements that can be made here but this is a good first step if it safely unblocks us Co-authored-by: Lo Kim <lo.kim@shopify.com>
juzser
pushed a commit
to juzser/polaris
that referenced
this pull request
Jul 27, 2023
Fixes nested Boxes spacing issues in Safari and Chromatic 🎩 changes on the layout beta branch [here](Shopify#7903) I think there are still improvements that can be made here but this is a good first step if it safely unblocks us Co-authored-by: Lo Kim <lo.kim@shopify.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proof of concept for #7904