Refactor AccountConnection with new layout and type components
#7345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
size-limit report 📦
|
SeanyB
reviewed
Oct 5, 2022
|
|
||
| const termsOfServiceMarkup = termsOfService ? ( | ||
| <div className={styles.TermsOfService}>{termsOfService}</div> | ||
| <Box paddingTop="5">{termsOfService}</Box> |
Contributor
There was a problem hiding this comment.
Shouldn't we be using tokens, rather than hardcoded numbers?
Contributor
There was a problem hiding this comment.
Oh, wait. I see. This is a number from the set made available in the Box component props. 🤦
Contributor
Author
There was a problem hiding this comment.
Yes it maps to our spacing tokens. But perhaps it's not very clear? I wonder if there's anything we can do to make that easier?
aveline
added a commit
that referenced
this pull request
Oct 12, 2022
### WHY are these changes introduced? #7345 Refactors the `AccountConnection` component to use the new layout primitives including `AlphaCard`. `AlphaCard` uses `useBreakpoints()` which required setting up a mock to set media width for the tests. It appears setting the media width in the tests becomes necessary for any parent components using a component that uses `useBreakpoints()`. ### WHAT is this pull request doing? This adds a `setMediaWidth` test utility which can be used in tests for any components that require mocked media widths in their tests. Co-authored-by: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com>
aveline
force-pushed
the
layout-account-connection
branch
from
3468945 to
db25106
Compare
aveline
force-pushed
the
layout-account-connection
branch
from
db25106 to
69e2dfc
Compare
alex-page
approved these changes
Oct 12, 2022
laurkim
approved these changes
Oct 12, 2022
Contributor
laurkim
left a comment
laurkim
left a comment
There was a problem hiding this comment.
Nice!! Changes on Storybook lgtm 🚀
laurkim
pushed a commit
that referenced
this pull request
Oct 14, 2022
### WHY are these changes introduced? Fixes #7341 <!-- link to issue if one exists -->
laurkim
pushed a commit
that referenced
this pull request
Oct 27, 2022
### WHY are these changes introduced? Fixes #7341 <!-- link to issue if one exists -->
laurkim
pushed a commit
that referenced
this pull request
Oct 28, 2022
### WHY are these changes introduced? Fixes #7341 <!-- link to issue if one exists -->
laurkim
pushed a commit
that referenced
this pull request
Oct 28, 2022
### WHY are these changes introduced? Fixes #7341 <!-- link to issue if one exists -->
chazdean
pushed a commit
that referenced
this pull request
Nov 22, 2022
Fixes #7341 <!-- link to issue if one exists -->
laurkim
pushed a commit
that referenced
this pull request
Nov 23, 2022
Fixes #7341 <!-- link to issue if one exists -->
chazdean
pushed a commit
that referenced
this pull request
Nov 28, 2022
Fixes #7341 <!-- link to issue if one exists -->
laurkim
pushed a commit
that referenced
this pull request
Dec 5, 2022
Fixes #7341 <!-- link to issue if one exists -->
laurkim
pushed a commit
that referenced
this pull request
Dec 7, 2022
Fixes #7341 <!-- link to issue if one exists -->
laurkim
pushed a commit
that referenced
this pull request
Dec 9, 2022
Fixes #7341 <!-- link to issue if one exists -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #7341