Update ChoiceList to use Layout primitives
#7751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### WHY are these changes introduced? Fixes #7341 <!-- link to issue if one exists -->
### WHY are these changes introduced? Fixes #7358 ### WHAT is this pull request doing? Refactors `Banner` component to use new layout primitive components
### WHY are these changes introduced? Resolves #7340. Refactors `Modal` and its child components to use our layout primitives. ### WHAT is this pull request doing? [Storybook URL](https://5d559397bae39100201eedc1-nrruulmwsh.chromatic.com/?path=/story/all-components-modal--default). Refactors `Modal`, `Modal.Section`, `Modal.Header`, and `Modal.Footer` to use our layout primitives and remove css. ### How to 🎩 [Storybook URL](https://5d559397bae39100201eedc1-nrruulmwsh.chromatic.com/?path=/story/all-components-modal--default). I've tophatted all of our stories as well as the UI for all of our breakpoints. 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [x] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
I'm still of the opinion that our layout components should have some defaults and the ones we have on bleed may not be right but we need to use it in more places to figure out what those defaults should be. For now, this fixes regressions to Banner that were introduced in #7644
Contributor
size-limit report 📦
|
aveline
requested review from
chazdean,
kyledurand,
laurkim,
nayeobkim and
sarahill
laurkim
reviewed
Nov 22, 2022
laurkim
reviewed
Nov 22, 2022
Co-authored-by: Lo Kim <lo.kim@shopify.com>
sarahill
reviewed
Nov 22, 2022
Contributor
sarahill
left a comment
sarahill
left a comment
There was a problem hiding this comment.
@aveline this looks ok. I would prefer to keep spacing between 16px instead of the 20px due to the space-1 but I understand why that's there. A potential alternative is to make the spacing on the help text responsive too but it may not be worth adding that complexity for this. Thoughts?
Contributor
Author
|
@sarahill the help text is part of But you did give me an idea, maybe I can add a responsive |
Contributor
|
Cool I'll trust your judgement on using |
sarahill
approved these changes
Nov 22, 2022
laurkim
force-pushed
the
layout-components-beta
branch
from
8e25493 to
54cdf64
Compare
chazdean
pushed a commit
that referenced
this pull request
Nov 28, 2022
Resolves #7354 - Refactored `ChoiceList` to use primitive Layout components - Added support for `legend` element to `Box` - Add support for `fieldset` element to `AlphaStack` There should be no visual changes. Co-authored-by: Lo Kim <lo.kim@shopify.com> Co-authored-by: Kyle Durand <kyledurand@users.noreply.github.com>
laurkim
added a commit
that referenced
this pull request
Dec 5, 2022
Resolves #7354 - Refactored `ChoiceList` to use primitive Layout components - Added support for `legend` element to `Box` - Add support for `fieldset` element to `AlphaStack` There should be no visual changes. Co-authored-by: Lo Kim <lo.kim@shopify.com> Co-authored-by: Kyle Durand <kyledurand@users.noreply.github.com>
laurkim
added a commit
that referenced
this pull request
Dec 7, 2022
Resolves #7354 - Refactored `ChoiceList` to use primitive Layout components - Added support for `legend` element to `Box` - Add support for `fieldset` element to `AlphaStack` There should be no visual changes. Co-authored-by: Lo Kim <lo.kim@shopify.com> Co-authored-by: Kyle Durand <kyledurand@users.noreply.github.com>
laurkim
added a commit
that referenced
this pull request
Dec 9, 2022
Resolves #7354 - Refactored `ChoiceList` to use primitive Layout components - Added support for `legend` element to `Box` - Add support for `fieldset` element to `AlphaStack` There should be no visual changes. Co-authored-by: Lo Kim <lo.kim@shopify.com> Co-authored-by: Kyle Durand <kyledurand@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Resolves #7354
WHAT is this pull request doing?
ChoiceListto use primitive Layout componentslegendelement toBoxfieldsetelement toAlphaStackHow to 🎩
There is only one small visual change for
ChoiceLists with Help text on small screens only. There isspace-1additional spacing between items which ismarginon Help Text that long longer overlaps into the space betweenChoicesnow that the space is set withgapinAlphaStack. Previously it was set withmarginso they overlapped.Otherwise there should be no visual changes.