Fix responsive props, remove fallback #7904
Merged
+68
−91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
size-limit report 📦
|
Co-authored-by: Kyle Durand <kyle.durand@shopify.com>
kyledurand
added
Blocking public Comms
Bug
Closed
chazdean
approved these changes
Dec 13, 2022
aveline
reviewed
Dec 13, 2022
| 'padding-block-end', | ||
| 'space', | ||
| paddingBlockEnd, | ||
| paddingBlockEnd || padding, |
aveline
approved these changes
Dec 13, 2022
Contributor
aveline
left a comment
aveline
left a comment
There was a problem hiding this comment.
This gets us unblocked for now and we can iterate on our approach 👍
Merged
laurkim
pushed a commit
that referenced
this pull request
Dec 15, 2022
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris@10.16.1 ### Patch Changes - [#7904](#7904) [`bdc62ebbb`](bdc62eb) Thanks [@kyledurand](https://github.com/kyledurand)! - Fixed a bug where responsive props would inherit values on Box - [#7911](#7911) [`b26408e2f`](b26408e) Thanks [@bencmilton](https://github.com/bencmilton)! - Fix validateDOMNesting warning in `VideoThumbnail` ## @shopify/plugin-polaris@0.0.22 ## polaris.shopify.com@0.27.3 ### Patch Changes - Updated dependencies \[[`bdc62ebbb`](bdc62eb), [`b26408e2f`](b26408e)]: - @shopify/polaris@10.16.1 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Merged
juzser
pushed a commit
to juzser/polaris
that referenced
this pull request
Jul 27, 2023
Fixes nested Boxes spacing issues in Safari and Chromatic 🎩 changes on the layout beta branch [here](Shopify#7903) I think there are still improvements that can be made here but this is a good first step if it safely unblocks us Co-authored-by: Lo Kim <lo.kim@shopify.com>
juzser
pushed a commit
to juzser/polaris
that referenced
this pull request
Jul 27, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris@10.16.1 ### Patch Changes - [Shopify#7904](Shopify#7904) [`bdc62ebbb`](Shopify@bdc62eb) Thanks [@kyledurand](https://github.com/kyledurand)! - Fixed a bug where responsive props would inherit values on Box - [Shopify#7911](Shopify#7911) [`b26408e2f`](Shopify@b26408e) Thanks [@bencmilton](https://github.com/bencmilton)! - Fix validateDOMNesting warning in `VideoThumbnail` ## @shopify/plugin-polaris@0.0.22 ## polaris.shopify.com@0.27.3 ### Patch Changes - Updated dependencies \[[`bdc62ebbb`](Shopify@bdc62eb), [`b26408e2f`](Shopify@b26408e)]: - @shopify/polaris@10.16.1 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes nested Boxes spacing issues in Safari and Chromatic
🎩 changes on the layout beta branch here
I think there are still improvements that can be made here but this is a good first step if it safely unblocks us