refactor: move dot-env dep to the callers (out of fed-sdk) #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #97 +/- ##
==========================================
+ Coverage 50.03% 50.29% +0.26%
==========================================
Files 77 77
Lines 8295 8305 +10
==========================================
+ Hits 4150 4177 +27
+ Misses 4145 4128 -17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ricardogarim
approved these changes
Jul 29, 2025
ricardogarim
pushed a commit
that referenced
this pull request
Jul 29, 2025
* refactor: move dot-env dep to the callers (out of fed-sdk) * fix: lint
ricardogarim
pushed a commit
that referenced
this pull request
Jul 30, 2025
* refactor: move dot-env dep to the callers (out of fed-sdk) * fix: lint
ricardogarim
added a commit
that referenced
this pull request
Jul 31, 2025
* refactor: move dot-env dep to the callers (out of fed-sdk) (#97) * refactor: move dot-env dep to the callers (out of fed-sdk) * fix: lint * commit before sleeping :p * commit everything to not lose * with invites * ci * ci 2 * more small * ci 3 * ci: do not lint js or generated files * ci: no emit files during build * better typings * migrate test cases * Revert "conflict -n" This reverts commit 778a2ce. * Revert "Revert "conflict -n"" This reverts commit d1319cf. * maybe * this is why i don't like magic * chore: better zod typings and misc fixes on PersistentEventBase wrapper (#75) * . * remove the test that doesn't have the required changes in this pr * chore!: remove v1 and v2 room version support (#76) * . * remove the test that doesn't have the required changes in this pr * remove v1 and v2 * don't forget it deb * less diff * reset lint changes * no generator use * lost changes * forgotten * ... * send stripped state too * send message yeah (#94) * feat: adds set and unset reactions events * chore: fixes biome format * fix: general fixes where the _id references were wrong * fix: prev_events should now look to eventId instead of _id * feat: makes set and unset reactions compliant with new state approach * x * reverts files * removes eventId mentions by _id * reverts files * reverts files * reverts files * reverts files * reverts files * reverts files * adds reaction event publishing via emitter * chore: simplifies configs attrs and keep just one config service * chore: adjusts unseting reactions from rc * fix: fixes queue processing * chore: makes persistTimelineEvent sendEventToAllServersInRoom void calls * makes persistTimelineEvent to be awaited --------- Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat> Co-authored-by: Debdut Chakraborty <debdutdeb@outlook.com> Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ricardogarim
added a commit
that referenced
this pull request
Aug 3, 2025
* refactor: move dot-env dep to the callers (out of fed-sdk) (#97) * refactor: move dot-env dep to the callers (out of fed-sdk) * fix: lint * commit before sleeping :p * commit everything to not lose * with invites * ci * ci 2 * more small * ci 3 * ci: do not lint js or generated files * ci: no emit files during build * better typings * migrate test cases * Revert "conflict -n" This reverts commit 778a2ce. * Revert "Revert "conflict -n"" This reverts commit d1319cf. * maybe * this is why i don't like magic * chore: better zod typings and misc fixes on PersistentEventBase wrapper (#75) * . * remove the test that doesn't have the required changes in this pr * chore!: remove v1 and v2 room version support (#76) * . * remove the test that doesn't have the required changes in this pr * remove v1 and v2 * don't forget it deb * less diff * reset lint changes * no generator use * lost changes * forgotten * ... * send stripped state too * send message yeah (#94) * feat: adds set and unset reactions events * chore: fixes biome format * fix: general fixes where the _id references were wrong * fix: prev_events should now look to eventId instead of _id * feat: makes set and unset reactions compliant with new state approach * x * reverts files * removes eventId mentions by _id * reverts files * reverts files * reverts files * reverts files * reverts files * reverts files * adds reaction event publishing via emitter * chore: simplifies configs attrs and keep just one config service * chore: adjusts unseting reactions from rc * fix: fixes queue processing * chore: makes persistTimelineEvent sendEventToAllServersInRoom void calls * feat: adds set and unset reactions events * use new server-discovery everywhere * get help from typescript * chore: adds leave and kick events * x * x * x * x * x * brings back removed files * adjusts room service to comply with new state format * publishes membership event to rocketchat * adjusts internal routes to remove targetServer from input body * makes newMembershipEvent accepts reason as optional param --------- Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat> Co-authored-by: Debdut Chakraborty <debdutdeb@outlook.com> Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://rocketchat.atlassian.net/browse/FDR-88