Skip to content

Conversation

@debdutdeb
Copy link
Member

No description provided.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 11.70213% with 83 lines in your changes missing coverage. Please review.

Project coverage is 50.21%. Comparing base (b5da839) to head (ef97bce).

Files with missing lines Patch % Lines
...kages/federation-sdk/src/services/state.service.ts 0.00% 55 Missing ⚠️
packages/room/src/manager/factory.ts 3.44% 28 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                   @@
##           join-room-actually      #94      +/-   ##
======================================================
- Coverage               50.63%   50.21%   -0.43%     
======================================================
  Files                      76       76              
  Lines                    8140     8231      +91     
======================================================
+ Hits                     4122     4133      +11     
- Misses                   4018     4098      +80     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ricardogarim ricardogarim marked this pull request as ready for review July 28, 2025 00:57
@ricardogarim ricardogarim merged commit 82d4187 into join-room-actually Jul 28, 2025
2 checks passed
ricardogarim pushed a commit that referenced this pull request Jul 28, 2025
* commit before sleeping :p

* commit everything to not lose

* fix signature problem

* with invites

* .

* ci

* ci 2

* move room creation to service

* move invite user to service

* small type handling improvement

* misc

* more small

* ci 3

* ci: do not lint js or generated files

* ci: no emit files during build

* fix room package tests

* better typings

* migrate test cases

* fix event signing

* conflict -1

* conflict -2

* conflict -3

* conflict -4

* conflict -n

* Revert "conflict -n"

This reverts commit 778a2ce.

* Revert "Revert "conflict -n""

This reverts commit d1319cf.

* fix room package stuff

* maybe

* fix final test

* maybe now

* less diff

* chore: change inject StagingAreaService into StagingAreaListener and MissingEventListener, and register FederationService in homeserver module

* this is why i don't like magic

* what i messed up during rebase

* chore: better zod typings and misc fixes on PersistentEventBase wrapper (#75)

* .

* remove the test that doesn't have the required changes in this pr

* chore!: remove v1 and v2 room version support (#76)

* .

* remove the test that doesn't have the required changes in this pr

* remove v1 and v2

* don't forget it deb

* ..

* less diff

* merge o'merge

* reset lint changes

* no generator use

* move join user to room service

* lost changes

* forgotten

* forgotten

* feat: send txn simple impl (#85)

* fix txn issues (#86)

* ...

* reduce diff

* move send_join to service

* also fix state at event

* variablaize

* accept invites too

* revert hardcoded serverName

* feat: create room with state design (#92)

* create room with state design

* fix: missing awaits

---------

Co-authored-by: Marcos Defendi <marcos.defendi@rocket.chat>

* move make_join to its place

* lint

* send stripped state too

* send message yeah

* send message yeah (#94)

* messages

* ...

---------

Co-authored-by: Marcos Defendi <marcos.defendi@rocket.chat>
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ricardogarim pushed a commit that referenced this pull request Jul 28, 2025
ricardogarim pushed a commit that referenced this pull request Jul 30, 2025
ricardogarim pushed a commit that referenced this pull request Jul 30, 2025
ricardogarim added a commit that referenced this pull request Jul 31, 2025
* refactor: move dot-env dep to the callers (out of fed-sdk) (#97)

* refactor: move dot-env dep to the callers (out of fed-sdk)

* fix: lint

* commit before sleeping :p

* commit everything to not lose

* with invites

* ci

* ci 2

* more small

* ci 3

* ci: do not lint js or generated files

* ci: no emit files during build

* better typings

* migrate test cases

* Revert "conflict -n"

This reverts commit 778a2ce.

* Revert "Revert "conflict -n""

This reverts commit d1319cf.

* maybe

* this is why i don't like magic

* chore: better zod typings and misc fixes on PersistentEventBase wrapper (#75)

* .

* remove the test that doesn't have the required changes in this pr

* chore!: remove v1 and v2 room version support (#76)

* .

* remove the test that doesn't have the required changes in this pr

* remove v1 and v2

* don't forget it deb

* less diff

* reset lint changes

* no generator use

* lost changes

* forgotten

* ...

* send stripped state too

* send message yeah (#94)

* feat: adds set and unset reactions events

* chore: fixes biome format

* fix: general fixes where the _id references were wrong

* fix: prev_events should now look to eventId instead of _id

* feat: makes set and unset reactions compliant with new state approach

* x

* reverts files

* removes eventId mentions by _id

* reverts files

* reverts files

* reverts files

* reverts files

* reverts files

* reverts files

* adds reaction event publishing via emitter

* chore: simplifies configs attrs and keep just one config service

* chore: adjusts unseting reactions from rc

* fix: fixes queue processing

* chore: makes persistTimelineEvent sendEventToAllServersInRoom void calls

* makes persistTimelineEvent to be awaited

---------

Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
Co-authored-by: Debdut Chakraborty <debdutdeb@outlook.com>
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ricardogarim added a commit that referenced this pull request Aug 3, 2025
* refactor: move dot-env dep to the callers (out of fed-sdk) (#97)

* refactor: move dot-env dep to the callers (out of fed-sdk)

* fix: lint

* commit before sleeping :p

* commit everything to not lose

* with invites

* ci

* ci 2

* more small

* ci 3

* ci: do not lint js or generated files

* ci: no emit files during build

* better typings

* migrate test cases

* Revert "conflict -n"

This reverts commit 778a2ce.

* Revert "Revert "conflict -n""

This reverts commit d1319cf.

* maybe

* this is why i don't like magic

* chore: better zod typings and misc fixes on PersistentEventBase wrapper (#75)

* .

* remove the test that doesn't have the required changes in this pr

* chore!: remove v1 and v2 room version support (#76)

* .

* remove the test that doesn't have the required changes in this pr

* remove v1 and v2

* don't forget it deb

* less diff

* reset lint changes

* no generator use

* lost changes

* forgotten

* ...

* send stripped state too

* send message yeah (#94)

* feat: adds set and unset reactions events

* chore: fixes biome format

* fix: general fixes where the _id references were wrong

* fix: prev_events should now look to eventId instead of _id

* feat: makes set and unset reactions compliant with new state approach

* x

* reverts files

* removes eventId mentions by _id

* reverts files

* reverts files

* reverts files

* reverts files

* reverts files

* reverts files

* adds reaction event publishing via emitter

* chore: simplifies configs attrs and keep just one config service

* chore: adjusts unseting reactions from rc

* fix: fixes queue processing

* chore: makes persistTimelineEvent sendEventToAllServersInRoom void calls

* feat: adds set and unset reactions events

* use new server-discovery everywhere

* get help from typescript

* chore: adds leave and kick events

* x

* x

* x

* x

* x

* brings back removed files

* adjusts room service to comply with new state format

* publishes membership event to rocketchat

* adjusts internal routes to remove targetServer from input body

* makes newMembershipEvent accepts reason as optional param

---------

Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
Co-authored-by: Debdut Chakraborty <debdutdeb@outlook.com>
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants