Skip to content

Conversation

@ricardogarim
Copy link
Contributor

@ricardogarim ricardogarim commented Jul 17, 2025

wip – built on top of feat/federation-reactions, should be merged right after that one.

As per FDR-60, FDR-62, and FDR-85, this pr covers the following use cases:

  1. User leaves a channel from Rocket.Chat
  2. User leaves a room from another matrix node and we process it via homeserver

The following use cases won’t be fully tested right now and will be revisited soon, once power level changes are merged - since they rely on permission updates and will be a good opportunity to better understand how those features behave:

  1. User gets kicked from another matrix node and we process it via homeserver
  2. User with admin rights removes another user from Rocket.Chat

Must be tested along with RocketChat/Rocket.Chat#36572.

@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2025

Codecov Report

❌ Patch coverage is 10.06289% with 143 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.84%. Comparing base (92f0a27) to head (70a5b21).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/room/src/manager/factory.ts 2.85% 68 Missing ⚠️
...ederation-sdk/src/services/staging-area.service.ts 3.92% 49 Missing ⚠️
...es/federation-sdk/src/queues/staging-area.queue.ts 10.52% 17 Missing ⚠️
.../federation-sdk/src/services/federation.service.ts 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #83      +/-   ##
==========================================
- Coverage   49.50%   48.84%   -0.67%     
==========================================
  Files          76       76              
  Lines        8427     8564     +137     
==========================================
+ Hits         4172     4183      +11     
- Misses       4255     4381     +126     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@debdutdeb debdutdeb changed the base branch from main to feat/emitter-reactions July 31, 2025 13:23
@debdutdeb debdutdeb changed the base branch from feat/emitter-reactions to main July 31, 2025 13:24
@ricardogarim ricardogarim changed the title feat: emitter leave feat: adds leave and kick support Aug 1, 2025
@ricardogarim ricardogarim merged commit 4a652f4 into main Aug 3, 2025
2 checks passed
@sampaiodiego sampaiodiego deleted the feat/emitter-leave branch September 26, 2025 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants