Skip to content

feat: message reactions#79

Merged
ricardogarim merged 48 commits intomainfrom
feat/emitter-reactions
Jul 31, 2025
Merged

feat: message reactions#79
ricardogarim merged 48 commits intomainfrom
feat/emitter-reactions

Conversation

@ricardogarim
Copy link
Contributor

@ricardogarim ricardogarim commented Jul 15, 2025

As per FDR-61, this PR adds support for reactions with four testable use cases:

  1. set message reaction from the Rocket.Chat side
  2. unset message reaction from the Rocket.Chat side
  3. receive a reaction from a matrix node
  4. receive an unset reaction from a matrix node

must be tested alongside: RocketChat/Rocket.Chat#36420.

@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2025

Codecov Report

❌ Patch coverage is 11.18881% with 127 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.10%. Comparing base (9595ed8) to head (b7b3e2f).

Files with missing lines Patch % Lines
packages/room/src/manager/factory.ts 2.85% 68 Missing ⚠️
...ederation-sdk/src/services/staging-area.service.ts 5.71% 33 Missing ⚠️
...es/federation-sdk/src/queues/staging-area.queue.ts 10.52% 17 Missing ⚠️
.../federation-sdk/src/services/federation.service.ts 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #79      +/-   ##
==========================================
- Coverage   49.67%   49.10%   -0.58%     
==========================================
  Files          76       76              
  Lines        8457     8578     +121     
==========================================
+ Hits         4201     4212      +11     
- Misses       4256     4366     +110     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ricardogarim ricardogarim force-pushed the feat/emitter-reactions branch 2 times, most recently from 7ed4316 to e0f88d1 Compare July 28, 2025 01:59
@ricardogarim ricardogarim changed the base branch from main to join-room-actually July 28, 2025 02:03
@ricardogarim ricardogarim force-pushed the feat/emitter-reactions branch 4 times, most recently from f486948 to 01f5670 Compare July 28, 2025 02:09
@ricardogarim ricardogarim changed the title feat: event emitter for reactions feat: message reactions Jul 28, 2025
@ricardogarim ricardogarim marked this pull request as draft July 28, 2025 03:03
@ricardogarim ricardogarim force-pushed the feat/emitter-reactions branch from 4f8022f to 10ebb03 Compare July 28, 2025 12:47
@ricardogarim ricardogarim changed the base branch from join-room-actually to main July 28, 2025 21:45
@ricardogarim ricardogarim force-pushed the feat/emitter-reactions branch 2 times, most recently from 2597951 to 5a419a4 Compare July 30, 2025 00:26
@ricardogarim ricardogarim marked this pull request as ready for review July 30, 2025 10:12
@ricardogarim ricardogarim force-pushed the feat/emitter-reactions branch from e9aee56 to 5edd6d3 Compare July 30, 2025 11:00
@ricardogarim ricardogarim force-pushed the feat/emitter-reactions branch from 576903e to 5edd6d3 Compare July 30, 2025 21:20
@ricardogarim ricardogarim merged commit 988239b into main Jul 31, 2025
2 checks passed
@sampaiodiego sampaiodiego deleted the feat/emitter-reactions branch September 26, 2025 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants