Chore: ESLint warnings #26504
Merged
Chore: ESLint warnings #26504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tassoevan
force-pushed
the
fix/eslint-warnings
branch
from
07b9566 to
8770398
Compare
Codecov Report
@@ Coverage Diff @@
## develop #26504 +/- ##
===========================================
- Coverage 38.06% 38.06% -0.01%
===========================================
Files 745 745
Lines 18628 18625 -3
Branches 1419 1412 -7
===========================================
- Hits 7091 7089 -2
+ Misses 11317 11313 -4
- Partials 220 223 +3
Flags with carried forward coverage won't be shown. Click here to find out more. |
ggazzo
approved these changes
Aug 8, 2022
gabriellsh
added a commit
that referenced
this pull request
Aug 8, 2022
…homepage * 'develop' of github.com:RocketChat/Rocket.Chat: (39 commits) Chore: ESLint warnings (#26504) Chore: Remove settings Fibers usage (#26465) Chore: Refactor create-target-channel util (#26493) Chore: useEndpointData deprecation (#26494) [NEW] Surface featured apps endpoint (#26416) [FIX] Request at least one field in the payload of `/v1/users.setStatus` (#26490) Chore: Exit process on `unhandledRejection` on CI (#26467) [FIX] Clear push token on save user password (#26466) [FIX] Undefined MediaDevices error on HTTP (#26396) Chore: Codecov threshold (#26477) Chore: Tests intermitences (#26464) [FIX] Don't give errors on outbound voip call Request Terminated (#26373) Chore: Use Docker compose on CI (#26437) [FIX] DialPad call button from end to center (#26459) Chore: Parallelize e2e tests (#26390) [IMPROVE] use enter key to call using DialPad (#26454) Chore: Accounts/token to TS (#26434) Chore: Purge some unused modules (#26447) i18n: Language update from LingoHub 🤖 on 2022-08-01Z (#26429) Chore: Add end-to-end tests to teams listing in the `directory` endpoint (#26347) ...
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
The current amount of ESLint warning messages is overwhelming to properly debug serious issues. This PR aims to reduce them to a sane amount.
Issue(s)
Steps to test or reproduce
Further comments
I couldn't go further as many issues regarding type declarations are too complex to solve without more information.