Skip to content

Conversation

@sampaiodiego
Copy link
Member

@sampaiodiego sampaiodiego commented Aug 1, 2022

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Maybe the new file docker-compose-ci.yml can be moved somewhere else, it doesn't need to in the project root.

@ggazzo ggazzo added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Aug 1, 2022
@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

Merging #26437 (d26603c) into develop (6b4ae48) will decrease coverage by 0.94%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #26437      +/-   ##
===========================================
- Coverage    39.11%   38.16%   -0.95%     
===========================================
  Files          749      745       -4     
  Lines        18653    18622      -31     
  Branches      1425     1418       -7     
===========================================
- Hits          7296     7108     -188     
- Misses       11133    11292     +159     
+ Partials       224      222       -2     
Flag Coverage Δ
e2e 38.16% <ø> (-0.95%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
apps/meteor/app/ui/client/lib/UserCard.js 14.28% <0.00%> (-82.15%) ⬇️
...meteor/client/lib/portals/createEphemeralPortal.ts 33.33% <0.00%> (-66.67%) ⬇️
...r/client/startup/notifications/usersNameChanged.ts 33.33% <0.00%> (-66.67%) ⬇️
apps/meteor/app/e2e/client/events.js 50.00% <0.00%> (-50.00%) ⬇️
apps/meteor/lib/getUserEmailAddress.ts 50.00% <0.00%> (-50.00%) ⬇️
...ps/meteor/client/lib/utils/getUserEmailVerified.ts 50.00% <0.00%> (-50.00%) ⬇️
...s/meteor/client/lib/portals/portalsSubscription.ts 47.61% <0.00%> (-47.62%) ⬇️
apps/meteor/client/startup/usersObserve.ts 58.33% <0.00%> (-41.67%) ⬇️
apps/meteor/client/views/root/PortalWrapper.ts 0.00% <0.00%> (-40.00%) ⬇️
...ews/admin/users/hooks/useChangeUserStatusAction.ts 4.76% <0.00%> (-38.10%) ⬇️
... and 67 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sampaiodiego sampaiodiego marked this pull request as ready for review August 3, 2022 13:59
@sampaiodiego sampaiodiego requested a review from a team as a code owner August 3, 2022 13:59
@kodiakhq kodiakhq bot removed the stat: ready to merge PR tested and approved waiting for merge label Aug 3, 2022
@kodiakhq
Copy link
Contributor

kodiakhq bot commented Aug 3, 2022

This PR currently has a merge conflict. Please resolve this and then re-add the ['stat: ready to merge', 'automerge'] label.

@ggazzo ggazzo added the stat: ready to merge PR tested and approved waiting for merge label Aug 3, 2022
@ggazzo ggazzo merged commit d61b3a4 into develop Aug 3, 2022
@ggazzo ggazzo deleted the use-compose-on-ci branch August 3, 2022 21:00
weslley543 pushed a commit that referenced this pull request Aug 4, 2022
gabriellsh added a commit that referenced this pull request Aug 4, 2022
…ove-e2ee-threadlist

* 'develop' of github.com:RocketChat/Rocket.Chat: (200 commits)
  [FIX] Undefined MediaDevices error on HTTP (#26396)
  Chore: Codecov threshold (#26477)
  Chore: Tests intermitences (#26464)
  [FIX] Don't give errors on outbound voip call Request Terminated (#26373)
  Chore: Use Docker compose on CI (#26437)
  [FIX] DialPad call button from end to center (#26459)
  Chore: Parallelize e2e tests (#26390)
  [IMPROVE] use enter key to call using DialPad (#26454)
  Chore: Accounts/token to TS (#26434)
  Chore: Purge some unused modules (#26447)
  i18n: Language update from LingoHub 🤖 on 2022-08-01Z (#26429)
  Chore: Add end-to-end tests to teams listing in the `directory` endpoint (#26347)
  Chore: Cache playwright (#26432)
  [FIX] Empty results on `im.list` endpoint (#26438)
  [IMPROVE] Upgrade nivo and React Query (#26338)
  Chore: Upgrade Fuselage packages to next dist-tag (#26435)
  Chore: Omnichannel endpoints e2e tests (#26376)
  Chore: Refactor UserInfo to typescript (#26323)
  Chore: Rewrite Location modal to React (#26196)
  Chore: Rewrite SaveToWebdav Modal to React Component (#24365)
  ...
gabriellsh added a commit that referenced this pull request Aug 8, 2022
…homepage

* 'develop' of github.com:RocketChat/Rocket.Chat: (39 commits)
  Chore: ESLint warnings (#26504)
  Chore: Remove settings Fibers usage (#26465)
  Chore: Refactor create-target-channel util (#26493)
  Chore: useEndpointData deprecation (#26494)
  [NEW] Surface featured apps endpoint  (#26416)
  [FIX] Request at least one field in the payload of `/v1/users.setStatus` (#26490)
  Chore: Exit process on `unhandledRejection` on CI (#26467)
  [FIX] Clear push token on save user password (#26466)
  [FIX] Undefined MediaDevices error on HTTP (#26396)
  Chore: Codecov threshold (#26477)
  Chore: Tests intermitences (#26464)
  [FIX] Don't give errors on outbound voip call Request Terminated (#26373)
  Chore: Use Docker compose on CI (#26437)
  [FIX] DialPad call button from end to center (#26459)
  Chore: Parallelize e2e tests (#26390)
  [IMPROVE] use enter key to call using DialPad (#26454)
  Chore: Accounts/token to TS (#26434)
  Chore: Purge some unused modules (#26447)
  i18n: Language update from LingoHub 🤖 on 2022-08-01Z (#26429)
  Chore: Add end-to-end tests to teams listing in the `directory` endpoint (#26347)
  ...
@murtaza98 murtaza98 mentioned this pull request Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants