Skip to content

Conversation

@tiagoevanp
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@tiagoevanp tiagoevanp marked this pull request as ready for review August 3, 2022 05:34
@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Merging #26459 (d82f0e1) into develop (6b4ae48) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop   #26459   +/-   ##
========================================
  Coverage    39.11%   39.11%           
========================================
  Files          749      749           
  Lines        18653    18653           
  Branches      1425     1425           
========================================
+ Hits          7296     7297    +1     
+ Misses       11133    11131    -2     
- Partials       224      225    +1     
Flag Coverage Δ
e2e 39.11% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
apps/meteor/app/ui-utils/client/lib/RoomManager.js 76.00% <0.00%> (-3.43%) ⬇️
...pps/meteor/app/ui-utils/client/lib/readMessages.js 62.02% <0.00%> (-2.54%) ⬇️
apps/meteor/client/hooks/useUpdateAvatar.ts 48.57% <0.00%> (ø)
apps/meteor/app/ui/client/views/app/room.js 49.59% <0.00%> (+0.20%) ⬆️
...ached-collection/client/models/CachedCollection.js 85.93% <0.00%> (+0.52%) ⬆️
...teor/app/ui-utils/client/lib/RoomHistoryManager.js 52.40% <0.00%> (+0.96%) ⬆️
apps/meteor/app/ui/client/lib/UserAction.ts 64.77% <0.00%> (+2.27%) ⬆️
apps/meteor/app/ui-utils/client/lib/openRoom.js 78.43% <0.00%> (+3.92%) ⬆️
...app/ui-message/client/popup/messagePopupChannel.js 100.00% <0.00%> (+50.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ggazzo ggazzo added the stat: ready to merge PR tested and approved waiting for merge label Aug 3, 2022
@kodiakhq kodiakhq bot merged commit 720566d into develop Aug 3, 2022
@kodiakhq kodiakhq bot deleted the fix/dial-call-button branch August 3, 2022 18:05
gabriellsh added a commit that referenced this pull request Aug 4, 2022
…ove-e2ee-threadlist

* 'develop' of github.com:RocketChat/Rocket.Chat: (200 commits)
  [FIX] Undefined MediaDevices error on HTTP (#26396)
  Chore: Codecov threshold (#26477)
  Chore: Tests intermitences (#26464)
  [FIX] Don't give errors on outbound voip call Request Terminated (#26373)
  Chore: Use Docker compose on CI (#26437)
  [FIX] DialPad call button from end to center (#26459)
  Chore: Parallelize e2e tests (#26390)
  [IMPROVE] use enter key to call using DialPad (#26454)
  Chore: Accounts/token to TS (#26434)
  Chore: Purge some unused modules (#26447)
  i18n: Language update from LingoHub 🤖 on 2022-08-01Z (#26429)
  Chore: Add end-to-end tests to teams listing in the `directory` endpoint (#26347)
  Chore: Cache playwright (#26432)
  [FIX] Empty results on `im.list` endpoint (#26438)
  [IMPROVE] Upgrade nivo and React Query (#26338)
  Chore: Upgrade Fuselage packages to next dist-tag (#26435)
  Chore: Omnichannel endpoints e2e tests (#26376)
  Chore: Refactor UserInfo to typescript (#26323)
  Chore: Rewrite Location modal to React (#26196)
  Chore: Rewrite SaveToWebdav Modal to React Component (#24365)
  ...
gabriellsh added a commit that referenced this pull request Aug 8, 2022
…homepage

* 'develop' of github.com:RocketChat/Rocket.Chat: (39 commits)
  Chore: ESLint warnings (#26504)
  Chore: Remove settings Fibers usage (#26465)
  Chore: Refactor create-target-channel util (#26493)
  Chore: useEndpointData deprecation (#26494)
  [NEW] Surface featured apps endpoint  (#26416)
  [FIX] Request at least one field in the payload of `/v1/users.setStatus` (#26490)
  Chore: Exit process on `unhandledRejection` on CI (#26467)
  [FIX] Clear push token on save user password (#26466)
  [FIX] Undefined MediaDevices error on HTTP (#26396)
  Chore: Codecov threshold (#26477)
  Chore: Tests intermitences (#26464)
  [FIX] Don't give errors on outbound voip call Request Terminated (#26373)
  Chore: Use Docker compose on CI (#26437)
  [FIX] DialPad call button from end to center (#26459)
  Chore: Parallelize e2e tests (#26390)
  [IMPROVE] use enter key to call using DialPad (#26454)
  Chore: Accounts/token to TS (#26434)
  Chore: Purge some unused modules (#26447)
  i18n: Language update from LingoHub 🤖 on 2022-08-01Z (#26429)
  Chore: Add end-to-end tests to teams listing in the `directory` endpoint (#26347)
  ...
@murtaza98 murtaza98 mentioned this pull request Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants