Skip to content

Conversation

@yash-rajpal
Copy link
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@yash-rajpal yash-rajpal requested review from a team as code owners August 1, 2022 14:06
@ggazzo ggazzo added the stat: ready to merge PR tested and approved waiting for merge label Aug 1, 2022
@RocketChat RocketChat deleted a comment from codecov bot Aug 2, 2022
@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

Merging #26434 (b1e4a28) into develop (d4deb4e) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #26434      +/-   ##
===========================================
- Coverage    39.08%   39.08%   -0.01%     
===========================================
  Files          748      749       +1     
  Lines        18647    18653       +6     
  Branches      1424     1425       +1     
===========================================
+ Hits          7289     7291       +2     
- Misses       11136    11138       +2     
- Partials       222      224       +2     
Flag Coverage Δ
e2e 39.08% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...meteor/client/components/AutoCompleteDepartment.js 71.42% <0.00%> (-14.29%) ⬇️
apps/meteor/app/otr/client/rocketchat.otr.js 41.81% <0.00%> (-1.82%) ⬇️
apps/meteor/app/ui-utils/client/lib/RoomManager.js 77.71% <0.00%> (-0.58%) ⬇️
...teor/app/ui-utils/client/lib/RoomHistoryManager.js 51.44% <0.00%> (-0.49%) ⬇️
...s/meteor/client/hooks/useResizeInlineBreakpoint.ts 50.00% <0.00%> (ø)
apps/meteor/app/ui/client/views/app/room.js 50.00% <0.00%> (+0.20%) ⬆️
apps/meteor/client/hooks/useForm.ts 91.07% <0.00%> (+7.14%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@dougfabris dougfabris force-pushed the chore/accounts-token-ts branch from b78da38 to b1e4a28 Compare August 2, 2022 01:18
@dougfabris dougfabris added this to the 5.1.0 milestone Aug 2, 2022
@ggazzo ggazzo merged commit 6b4ae48 into develop Aug 2, 2022
@ggazzo ggazzo deleted the chore/accounts-token-ts branch August 2, 2022 22:36
carlosrodrigues94 pushed a commit that referenced this pull request Aug 3, 2022
Co-authored-by: dougfabris <devfabris@gmail.com>
gabriellsh added a commit that referenced this pull request Aug 4, 2022
…ove-e2ee-threadlist

* 'develop' of github.com:RocketChat/Rocket.Chat: (200 commits)
  [FIX] Undefined MediaDevices error on HTTP (#26396)
  Chore: Codecov threshold (#26477)
  Chore: Tests intermitences (#26464)
  [FIX] Don't give errors on outbound voip call Request Terminated (#26373)
  Chore: Use Docker compose on CI (#26437)
  [FIX] DialPad call button from end to center (#26459)
  Chore: Parallelize e2e tests (#26390)
  [IMPROVE] use enter key to call using DialPad (#26454)
  Chore: Accounts/token to TS (#26434)
  Chore: Purge some unused modules (#26447)
  i18n: Language update from LingoHub 🤖 on 2022-08-01Z (#26429)
  Chore: Add end-to-end tests to teams listing in the `directory` endpoint (#26347)
  Chore: Cache playwright (#26432)
  [FIX] Empty results on `im.list` endpoint (#26438)
  [IMPROVE] Upgrade nivo and React Query (#26338)
  Chore: Upgrade Fuselage packages to next dist-tag (#26435)
  Chore: Omnichannel endpoints e2e tests (#26376)
  Chore: Refactor UserInfo to typescript (#26323)
  Chore: Rewrite Location modal to React (#26196)
  Chore: Rewrite SaveToWebdav Modal to React Component (#24365)
  ...
gabriellsh added a commit that referenced this pull request Aug 8, 2022
…homepage

* 'develop' of github.com:RocketChat/Rocket.Chat: (39 commits)
  Chore: ESLint warnings (#26504)
  Chore: Remove settings Fibers usage (#26465)
  Chore: Refactor create-target-channel util (#26493)
  Chore: useEndpointData deprecation (#26494)
  [NEW] Surface featured apps endpoint  (#26416)
  [FIX] Request at least one field in the payload of `/v1/users.setStatus` (#26490)
  Chore: Exit process on `unhandledRejection` on CI (#26467)
  [FIX] Clear push token on save user password (#26466)
  [FIX] Undefined MediaDevices error on HTTP (#26396)
  Chore: Codecov threshold (#26477)
  Chore: Tests intermitences (#26464)
  [FIX] Don't give errors on outbound voip call Request Terminated (#26373)
  Chore: Use Docker compose on CI (#26437)
  [FIX] DialPad call button from end to center (#26459)
  Chore: Parallelize e2e tests (#26390)
  [IMPROVE] use enter key to call using DialPad (#26454)
  Chore: Accounts/token to TS (#26434)
  Chore: Purge some unused modules (#26447)
  i18n: Language update from LingoHub 🤖 on 2022-08-01Z (#26429)
  Chore: Add end-to-end tests to teams listing in the `directory` endpoint (#26347)
  ...
@murtaza98 murtaza98 mentioned this pull request Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants