Skip to content

Conversation

@souzaramon
Copy link
Contributor

Proposed changes (including videos or screenshots)

  • Simplify pageobjects
  • Remove unused code

@souzaramon souzaramon force-pushed the test/refactor-pageobjects branch from d36fcdb to 564659d Compare June 26, 2022 04:23
@souzaramon souzaramon force-pushed the test/refactor-pageobjects branch from 01e6696 to 3e67f85 Compare June 27, 2022 01:54
@souzaramon souzaramon requested a review from weslley543 June 27, 2022 03:19
@souzaramon souzaramon marked this pull request as ready for review June 27, 2022 13:58
@souzaramon souzaramon requested a review from a team as a code owner June 27, 2022 13:58
@souzaramon souzaramon requested a review from ggazzo June 27, 2022 13:58
@github-actions github-actions bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Jun 27, 2022
@kodiakhq kodiakhq bot merged commit 89546dd into develop Jun 27, 2022
@kodiakhq kodiakhq bot deleted the test/refactor-pageobjects branch June 27, 2022 14:03
gabriellsh added a commit that referenced this pull request Jun 27, 2022
…turbo

* 'develop' of github.com:RocketChat/Rocket.Chat: (42 commits)
  Chore: Major refactors in pageobjects (#26015)
  [BREAK] Remove show message in main thread preference (#26002)
  Regression: Webhook Integration Creation + string error toast msg (#26008)
  Chore: convert e2e to ts (#25958)
  Regression: Room Endpoint Call Issues (#25928)
  Chore: Fixes e2e playwright intermittences (#25984)
  Chore: Fuselage update (#26004)
  Chore: Small fix on callProvider (#25963)
  [FIX] Initial members value on Create Channel Modal (#26000)
  Chore: Migrate from meteor model to raw (#25756)
  Chore: VoIP Context (#25994)
  Chore: Fuselage update (#25983)
  [FIX] sidebar colors (#25987)
  Regression: Non-reactive routes (#25990)
  [BREAK] use urlParams on omnichannel/agent/extension/ (#25982)
  [FIX] toolbox menu behind thread component (#25925)
  [FIX] Sort by scope or creation date not working on canned responses list (#25475)
  Chore: Colors (#25969)
  Revert "[BREAK] use urlParams on omnichannel/agent/extension/" (#25980)
  Regression: Prevent Form Submit on Reset Click
  ...
gabriellsh added a commit that referenced this pull request Jun 28, 2022
…ove/message-renderer-tweaks

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [NEW] Enable outbound calling for EE (#25843) (#25960)
  Chore: Introduce new index to query active livechat conversations for cloud scaling (#26047)
  [FIX] Importer fails to download files from URLs with query string params (#25934)
  [IMPROVE] Moved call hold/unhold to EE (#26007)
  [NEW] Engagement Metrics - Phase 2 (#25505)
  Chore: Convert usePreventDefault, useQueryOptions, useShortcutOpenMenu (#26035)
  [FIX] Importer files are unnecessarily transferred over the network. (#25919)
  Chore: test turbo params (#26038)
  Chore: Create a token for each action (#26023)
  Chore: Migrate oembed to ts (#25622)
  Regression: Fix voip call wrap-up model not working (#26024)
  Chore: Updating Apps-Engine  (#26001)
  [IMPROVE] Differ Voip calls from Incoming and Outgoing (#25643)
  [FIX] Append path To Route For Custom Emoji (#24379)
  [IMPROVE] Moved call wrap up modal to EE (#25875)
  Chore: Major refactors in pageobjects (#26015)
@murtaza98 murtaza98 mentioned this pull request Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants