Regression: Webhook Integration Creation + string error toast msg #26008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and 2FA enable/disable wrong endpoint
Contributor
Author
|
Found more paces without the "/v1/", being: |
debdutdeb
reviewed
Jun 24, 2022
debdutdeb
changed the title
`dispatchToastMessage` will handle `{error: string} | {message: string}` case accordingly, no need to forcefully cast or force member passing.
debdutdeb
approved these changes
Jun 26, 2022
debdutdeb
added
stat: ready to merge
ggazzo
approved these changes
Jun 27, 2022
ggazzo
changed the title
gabriellsh
added a commit
that referenced
this pull request
Jun 27, 2022
…turbo * 'develop' of github.com:RocketChat/Rocket.Chat: (42 commits) Chore: Major refactors in pageobjects (#26015) [BREAK] Remove show message in main thread preference (#26002) Regression: Webhook Integration Creation + string error toast msg (#26008) Chore: convert e2e to ts (#25958) Regression: Room Endpoint Call Issues (#25928) Chore: Fixes e2e playwright intermittences (#25984) Chore: Fuselage update (#26004) Chore: Small fix on callProvider (#25963) [FIX] Initial members value on Create Channel Modal (#26000) Chore: Migrate from meteor model to raw (#25756) Chore: VoIP Context (#25994) Chore: Fuselage update (#25983) [FIX] sidebar colors (#25987) Regression: Non-reactive routes (#25990) [BREAK] use urlParams on omnichannel/agent/extension/ (#25982) [FIX] toolbox menu behind thread component (#25925) [FIX] Sort by scope or creation date not working on canned responses list (#25475) Chore: Colors (#25969) Revert "[BREAK] use urlParams on omnichannel/agent/extension/" (#25980) Regression: Prevent Form Submit on Reset Click ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue(s)
While creating an webhook integration, it was missing the v1/. Also, the toast was not properly displaying error messages
Before:
After:
Steps to test or reproduce
Try creating an Integration Webhook in Admin > Integrations.
The payload will be sent to: http://localhost:3000/api/integrations.create
Edit a user, and set it's email the same email as an existing user: the toast message will not display the correct message