Skip to content

Conversation

@murtaza98
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

image

Steps to test or reproduce

Further comments

@murtaza98 murtaza98 requested a review from a team June 27, 2022 15:08
KevLehman
KevLehman previously approved these changes Jun 27, 2022
KevLehman
KevLehman previously approved these changes Jun 27, 2022
@KevLehman KevLehman added stat: QA skipped stat: ready to merge PR tested and approved waiting for merge labels Jun 27, 2022
@murtaza98 murtaza98 removed the stat: ready to merge PR tested and approved waiting for merge label Jun 27, 2022
@github-actions github-actions bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Jun 27, 2022
KevLehman
KevLehman previously approved these changes Jun 27, 2022
@murtaza98 murtaza98 marked this pull request as draft June 27, 2022 16:17
@murtaza98
Copy link
Contributor Author

Seems like some tests are breaking 🙈 Let me check until then making it draft

@murtaza98 murtaza98 added this to the 5.0.0 milestone Jun 27, 2022
@murtaza98 murtaza98 marked this pull request as ready for review June 27, 2022 16:54
@murtaza98
Copy link
Contributor Author

Seems like some tests are breaking see_no_evil Let me check until then making it draft

Fixed those build! This should be ready for review now

@kodiakhq kodiakhq bot merged commit ace6f5b into develop Jun 27, 2022
@kodiakhq kodiakhq bot deleted the voip/livechat-tag-fix branch June 27, 2022 19:47
gabriellsh added a commit that referenced this pull request Jun 28, 2022
…ove/message-renderer-tweaks

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [NEW] Enable outbound calling for EE (#25843) (#25960)
  Chore: Introduce new index to query active livechat conversations for cloud scaling (#26047)
  [FIX] Importer fails to download files from URLs with query string params (#25934)
  [IMPROVE] Moved call hold/unhold to EE (#26007)
  [NEW] Engagement Metrics - Phase 2 (#25505)
  Chore: Convert usePreventDefault, useQueryOptions, useShortcutOpenMenu (#26035)
  [FIX] Importer files are unnecessarily transferred over the network. (#25919)
  Chore: test turbo params (#26038)
  Chore: Create a token for each action (#26023)
  Chore: Migrate oembed to ts (#25622)
  Regression: Fix voip call wrap-up model not working (#26024)
  Chore: Updating Apps-Engine  (#26001)
  [IMPROVE] Differ Voip calls from Incoming and Outgoing (#25643)
  [FIX] Append path To Route For Custom Emoji (#24379)
  [IMPROVE] Moved call wrap up modal to EE (#25875)
  Chore: Major refactors in pageobjects (#26015)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants