[IMPROVE] Differ Voip calls from Incoming and Outgoing #25643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
The pipe fails, and seems like an actual fail 👀 can you take a look? |
KevLehman
reviewed
May 26, 2022
Member
KevLehman
left a comment
KevLehman
left a comment
There was a problem hiding this comment.
Pls check if voip/rooms endpoint can be filtered by the new prop too :)
tiagoevanp
previously requested changes
May 26, 2022
apps/meteor/client/views/omnichannel/directory/calls/CallTable.tsx
Outdated
Show resolved
Hide resolved
Contributor
Author
Alright! Added a new parameter there too, allowing filter by call direction |
murtaza98
dismissed
tiagoevanp’s stale review
Applied the type suggestions. Thanks Tiago :)
KevLehman
previously approved these changes
May 30, 2022
murtaza98
force-pushed
the
voip/ib_ob
branch
3 times, most recently
from
5d8592d to
d332b81
Compare
Member
|
Conflicts 😬 |
Contributor
Author
Fixed it 👍 |
added 7 commits
June 9, 2022 21:37
Member
|
New conflicts 😬 |
Contributor
Author
Haha... lots of changes happening here which is great!! Fixed the conflicts btw |
aleksandernsilva
previously approved these changes
Jun 24, 2022
murtaza98
commented
Jun 27, 2022
KevLehman
previously approved these changes
Jun 27, 2022
KevLehman
added
stat: QA skipped
stat: ready to merge
kodiakhq
bot
removed
the
stat: ready to merge
Contributor
|
This PR currently has a merge conflict. Please resolve this and then re-add the |
github-actions
bot
added
stat: ready to merge
Member
|
I can't see why we are skipping QA for this task |
Member
This can't be tested as it's BE mostly, and will be tested in another task |
KevLehman
approved these changes
Jun 27, 2022
sampaiodiego
approved these changes
Jun 27, 2022
tiagoevanp
approved these changes
Jun 27, 2022
KevLehman
added
stat: ready to merge
gabriellsh
added a commit
that referenced
this pull request
Jun 28, 2022
…ove/message-renderer-tweaks * 'develop' of github.com:RocketChat/Rocket.Chat: [NEW] Enable outbound calling for EE (#25843) (#25960) Chore: Introduce new index to query active livechat conversations for cloud scaling (#26047) [FIX] Importer fails to download files from URLs with query string params (#25934) [IMPROVE] Moved call hold/unhold to EE (#26007) [NEW] Engagement Metrics - Phase 2 (#25505) Chore: Convert usePreventDefault, useQueryOptions, useShortcutOpenMenu (#26035) [FIX] Importer files are unnecessarily transferred over the network. (#25919) Chore: test turbo params (#26038) Chore: Create a token for each action (#26023) Chore: Migrate oembed to ts (#25622) Regression: Fix voip call wrap-up model not working (#26024) Chore: Updating Apps-Engine (#26001) [IMPROVE] Differ Voip calls from Incoming and Outgoing (#25643) [FIX] Append path To Route For Custom Emoji (#24379) [IMPROVE] Moved call wrap up modal to EE (#25875) Chore: Major refactors in pageobjects (#26015)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Updated this column and its respective endpoints to support inbound/outfound call definitions
Issue(s)
Steps to test or reproduce
Further comments
Clickup: https://app.clickup.com/t/22bmc0f