Chore: Remove compose from main repo #23426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debdutdeb
commented
Oct 10, 2021
debdutdeb
commented
Oct 10, 2021
sampaiodiego
requested changes
Oct 11, 2021
Member
Author
|
@sampaiodiego review please :) |
Signed-off-by: Debdut Chakraborty <debdut.chakraborty@rocket.chat>
Signed-off-by: Debdut Chakraborty <debdut.chakraborty@rocket.chat>
Signed-off-by: Debdut Chakraborty <debdut.chakraborty@rocket.chat>
waylon-gmail
reviewed
Nov 5, 2021
Signed-off-by: Debdut Chakraborty <debdut.chakraborty@rocket.chat>
Signed-off-by: Debdut Chakraborty <debdut.chakraborty@rocket.chat>
Signed-off-by: Debdut Chakraborty <debdut.chakraborty@rocket.chat>
Signed-off-by: Debdut Chakraborty <debdut.chakraborty@rocket.chat>
Signed-off-by: Debdut Chakraborty <debdut.chakraborty@rocket.chat>
debdutdeb
force-pushed
the
prod-compose-update
branch
from
797faec to
78ccad2
Compare
debdutdeb
force-pushed
the
prod-compose-update
branch
from
5dc025a to
855a7f1
Compare
amottier
reviewed
May 5, 2022
amottier
reviewed
May 5, 2022
sampaiodiego
previously requested changes
May 10, 2022
debdutdeb
changed the title
Member
|
what if we just remove the docker-compose from here? it is already buried in |
Member
Author
|
Honestly, I don't have any problem with that 😂 this whole should-we-should-we-not started on a seperate github thread that brought the topic "people automate updating compose files right from repo". I always was against catering to such practice. Well, since we already changed the path with monorepo migration, I suppose that argument is moot now. |
Member
exactly.. it is already missing from the root of the repo where it used to be.. so I think that gives us green light to just delete it. |
Member
Author
|
I'll update the pr tomorrow. Also need to redirect to the other pr (to the new compose location) before merging/closing this one. |
debdutdeb
changed the title
geekgonecrazy
approved these changes
May 23, 2022
Contributor
|
Should we leave the file there with a note inside? Or a docker-compose.md with a note inside? |
Member
Author
|
IMO updating our docs should be enough :) |
debdutdeb
added
the
stat: ready to merge
gabriellsh
added a commit
that referenced
this pull request
Jun 10, 2022
…e/split-useUserInfoActions * 'develop' of github.com:RocketChat/Rocket.Chat: (41 commits) Regression: Fix apps wrong typing (#25824) Chore: Remove compose from main repo (#23426) [FIX] `You and @Yourusername reacted with`title on reactions (#25733) [FIX] AgentsPage pagination (#25820) Chore: Move voip's Wrap-up and On-hold functionality to EE (Backend) (#25160) [FIX] Access issue on chat.getThreadsList (#25750) Chore: Remove snap files from Houston config (#25819) [FIX] Voip endpoint permissions (#25783) [FIX] allow only livechat-agents to be contact manager for any omnichannel contact (#25451) Chore: use params instead of URL building on livechat endpoints (#25810) Regression: fix apps path (#25809) [BREAK] Remove RDStation integration (#25774) Chore: RestApiClient as Package (#25469) [FIX] Wrong argument name preventing Omnichannel Chat Forward to User (#25723) [FIX] AccountBox checks for condition (#25708) Chore: Fix CI (#25797) [FIX] Fix prom-client new promise usage (#25781) [FIX] Discussion alphabetical ordering (#25788) Update .kodiak.toml Update .kodiak.toml ...
gabriellsh
added a commit
that referenced
this pull request
Jun 13, 2022
…homepage * 'develop' of github.com:RocketChat/Rocket.Chat: (21 commits) [FIX] Client-generated sort parameters in channel directory (#25768) Chore: Add tests for agents screens (#25637) Chore: Notification Preferences to TS (#25827) Chore: Convert MemoizedSetting, Setting, Section (#25572) Regression: Fix users.create call (#25834) Chore: Add auto label and improve Kodiak configuration (#25829) Regression: Fix apps wrong typing (#25824) Chore: Remove compose from main repo (#23426) [FIX] `You and @Yourusername reacted with`title on reactions (#25733) [FIX] AgentsPage pagination (#25820) Chore: Move voip's Wrap-up and On-hold functionality to EE (Backend) (#25160) [FIX] Access issue on chat.getThreadsList (#25750) Chore: Remove snap files from Houston config (#25819) [FIX] Voip endpoint permissions (#25783) [FIX] allow only livechat-agents to be contact manager for any omnichannel contact (#25451) Chore: use params instead of URL building on livechat endpoints (#25810) Regression: fix apps path (#25809) [BREAK] Remove RDStation integration (#25774) Chore: RestApiClient as Package (#25469) [FIX] Wrong argument name preventing Omnichannel Chat Forward to User (#25723) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #23584
Closes #23416
Closes #23402
Closes #24636
Closes #24160
Closes #23479
Closes #23341