Skip to content

[FIX] allow only livechat-agents to be contact manager for any omnichannel contact #25451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kodiakhq merged 6 commits into from
Jun 9, 2022
Merged

[FIX] allow only livechat-agents to be contact manager for any omnichannel contact #25451

kodiakhq merged 6 commits into from
Jun 9, 2022

Conversation

@murtaza98
Copy link
Contributor

@murtaza98 murtaza98 commented May 10, 2022 •
edited
Loading

Proposed changes (including videos or screenshots)

Issue(s)

image

Steps to test or reproduce

Further comments

Tasks:

  • Frontend change on auto-select component
  • Backend API checks

@murtaza98 murtaza98 force-pushed the omni/contact-manager-filter branch 2 times, most recently from 58a12f3 to 2106bb7 Compare May 19, 2022 06:45
@murtaza98 murtaza98 marked this pull request as ready for review May 19, 2022 18:08
KevLehman
KevLehman reviewed May 19, 2022
View reviewed changes
Copy link
Member

@KevLehman KevLehman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if some random customer has a non-agent as contact manager? 👀

@murtaza98
Copy link
Contributor Author

murtaza98 commented May 20, 2022 •
edited
Loading

What if some random customer has a non-agent as contact manager? 👀

But that's not the way this feature was designed. The whole idea of the Contact manager is that if that manager is online and the visitor tries to contact the company, then the chat reaches directly to this manager instead of any other agent. So if a non-agent is assigned as a contact manager to any contact, then they won't be able to take the chat (since only agents can serve a chat) - hence I believe we need to add this filter over here to prevent such cases

@KevLehman
Copy link
Member

KevLehman commented May 23, 2022

No no, that's fine. I mean, what happens if some customer already has non-agents as contact managers after this fix is merged 👀
Will UI crash? Will something odd happen? 😬

@murtaza98
Copy link
Contributor Author

murtaza98 commented Jun 6, 2022

No no, that's fine. I mean, what happens if some customer already has non-agents as contact managers after this fix is merged eyes Will UI crash? Will something odd happen? grimacing

@KevLehman I checked this case & I didn't find anything odd. Nothing breaks on the UI, however the only thing is that the existing contact manager (who isn't a agent) won't appear in the select dropdown

KevLehman
KevLehman previously approved these changes Jun 6, 2022
View reviewed changes
@murtaza98 murtaza98 force-pushed the omni/contact-manager-filter branch from c015992 to f742551 Compare June 7, 2022 12:51
@murtaza98 murtaza98 requested a review from a team as a code owner June 7, 2022 12:51
@murtaza98 murtaza98 marked this pull request as draft June 7, 2022 13:08
@murtaza98
Copy link
Contributor Author

murtaza98 commented Jun 7, 2022

Making this a draft for now since blocked on agent's page not getting loaded

PS: suggestions from the QA team to handle a case for a user losing an agent role.

@murtaza98 murtaza98 force-pushed the omni/contact-manager-filter branch from f742551 to 44e5877 Compare June 8, 2022 08:28
@murtaza98 murtaza98 marked this pull request as ready for review June 8, 2022 08:28
@murtaza98
Copy link
Contributor Author

murtaza98 commented Jun 8, 2022

Hi @KevLehman @RocketChat/chat-engine May I ask for your approvals again? I lost earlier approvals due to some changes which QA team suggested

KevLehman
KevLehman reviewed Jun 8, 2022
View reviewed changes
@KevLehman KevLehman added the stat: ready to merge PR tested and approved waiting for merge label Jun 8, 2022
@ggazzo ggazzo changed the title [FIX] allow only livechat-agents to be contact manager for any omnichannel contact [FIX] allow only livechat-agents to be contact manager for any omnichannel contact Jun 9, 2022
@ggazzo ggazzo added this to the 5.0.0 milestone Jun 9, 2022
@kodiakhq kodiakhq bot merged commit 6b3908b into develop Jun 9, 2022
@kodiakhq kodiakhq bot deleted the omni/contact-manager-filter branch June 9, 2022 13:19
gabriellsh added a commit that referenced this pull request Jun 10, 2022
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into chor…
d17602f 
…e/split-useUserInfoActions

* 'develop' of github.com:RocketChat/Rocket.Chat: (41 commits)
  Regression: Fix apps wrong typing (#25824)
  Chore: Remove compose from main repo (#23426)
  [FIX] `You and @Yourusername reacted with`title on reactions (#25733)
  [FIX] AgentsPage pagination (#25820)
  Chore: Move voip's Wrap-up and On-hold functionality to EE (Backend) (#25160)
  [FIX] Access issue on chat.getThreadsList (#25750)
  Chore: Remove snap files from Houston config (#25819)
  [FIX] Voip endpoint permissions (#25783)
  [FIX] allow only livechat-agents to be contact manager for any omnichannel contact  (#25451)
  Chore: use params instead of URL building on livechat endpoints (#25810)
  Regression: fix apps path (#25809)
  [BREAK] Remove RDStation integration (#25774)
  Chore: RestApiClient as Package (#25469)
  [FIX] Wrong argument name preventing Omnichannel Chat Forward to User  (#25723)
  [FIX] AccountBox checks for condition (#25708)
  Chore: Fix CI (#25797)
  [FIX] Fix prom-client new promise usage (#25781)
  [FIX] Discussion alphabetical  ordering (#25788)
  Update .kodiak.toml
  Update .kodiak.toml
  ...
gabriellsh added a commit that referenced this pull request Jun 13, 2022
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into new/…
be7ff5f 
…homepage

* 'develop' of github.com:RocketChat/Rocket.Chat: (21 commits)
  [FIX] Client-generated sort parameters in channel directory  (#25768)
  Chore: Add tests for agents screens (#25637)
  Chore: Notification Preferences to TS (#25827)
  Chore: Convert MemoizedSetting, Setting, Section (#25572)
  Regression: Fix users.create call (#25834)
  Chore: Add auto label and improve Kodiak configuration (#25829)
  Regression: Fix apps wrong typing (#25824)
  Chore: Remove compose from main repo (#23426)
  [FIX] `You and @Yourusername reacted with`title on reactions (#25733)
  [FIX] AgentsPage pagination (#25820)
  Chore: Move voip's Wrap-up and On-hold functionality to EE (Backend) (#25160)
  [FIX] Access issue on chat.getThreadsList (#25750)
  Chore: Remove snap files from Houston config (#25819)
  [FIX] Voip endpoint permissions (#25783)
  [FIX] allow only livechat-agents to be contact manager for any omnichannel contact  (#25451)
  Chore: use params instead of URL building on livechat endpoints (#25810)
  Regression: fix apps path (#25809)
  [BREAK] Remove RDStation integration (#25774)
  Chore: RestApiClient as Package (#25469)
  [FIX] Wrong argument name preventing Omnichannel Chat Forward to User  (#25723)
  ...
@murtaza98 murtaza98 mentioned this pull request Jul 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ggazzo ggazzo ggazzo approved these changes

@KevLehman KevLehman KevLehman approved these changes

Assignees

No one assigned

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@murtaza98 @KevLehman @ggazzo