Skip to content

Conversation

@avimanyu786
Copy link

@avimanyu786 avimanyu786 commented Oct 8, 2021

Proposed changes

  • Updated services rocketchat and mongo-init-replica command for loops to run endlessly (as per migration guide - linked in this template).
  • Added migration guidelines for existing Rocket.Chat 3.x.y users in mongo service definition.
  • Also, updated the mongo and mongo-init-replica service definitions to use MongoDB 4.2 which is now a minimum requirement to make a quick transition. I understand this has already been requested in PR [FIX] Update Docker-compose.yml for Mongodb 4.2 #23402
  • Removed --smallfiles and --storageEngine=mmapv1 deprecated options within the mongod database server command.

Issue(s)

#23341

Further comments

Because of the recent breaking changes on the latest version, this update really helps as a migration & upgrade friendly template based on MongoDB 4.2, with necessary guidelines as comments inside the mongo service. Specifying the storage engine is no longer needed since wiredTiger is automatically set by default since MongoDB 3.2. The --smallfiles configuration option was also MMAPv1 specific (deprecated).

Because of the recent breaking changes on the latest version, this update really helps as a migration & upgrade friendly MongoDB 4.2 based template, with necessary guidelines as comments inside the `mongo` service. Specifying the storage engine is no longer needed since `wiredTiger` is automatically set by default since MongoDB 3.2. The `--smallfiles` configuration option was also MMAPv1 specific (deprecated).
@debdutdeb debdutdeb self-requested a review October 9, 2021 18:15
@avimanyu786
Copy link
Author

avimanyu786 commented Oct 12, 2021

Related PR: https://github.com/RocketChat/docs/pull/2019

New update based on requested changes for PR: RocketChat#23416
@CLAassistant
Copy link

CLAassistant commented Dec 17, 2021

CLA assistant check
All committers have signed the CLA.

@kodiakhq kodiakhq bot closed this in #23426 Jun 10, 2022
kodiakhq bot pushed a commit that referenced this pull request Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants