Skip to content

Conversation

@maciejmajek
Copy link
Member

Purpose

Simplifying rai-perception package management to pyproject.toml only

Proposed Changes

Removing ros2 setup files and launchfiles

Issues

  • Links to relevant issues

Testing

  • How was it tested, what were the results?

@maciejmajek maciejmajek requested a review from Juliaj November 13, 2025 19:34
@Juliaj
Copy link
Collaborator

Juliaj commented Nov 14, 2025

@maciejmajek, thanks for catching the missed doc changes. The launch file removals look good.

Regarding the setup file changes: I’m ambivalent. Until we publish rai-perception to PyPI and push the messages to rosdep, users still rely on these for ROS2 dependency resolution and colcon build. I suggest we defer these changes and I’ll include them in subsequent PRs. What do you think?

Base automatically changed from jj/feat/rai-perception-pkg to main November 15, 2025 08:49
@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.32%. Comparing base (c66f275) to head (7c94880).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #711   +/-   ##
=======================================
  Coverage   65.32%   65.32%           
=======================================
  Files          78       78           
  Lines        3386     3386           
=======================================
  Hits         2212     2212           
  Misses       1174     1174           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Juliaj Juliaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Juliaj Juliaj merged commit a0addd0 into main Nov 20, 2025
9 checks passed
@Juliaj Juliaj deleted the chore/derosify-rai-openset branch November 20, 2025 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants