-
Notifications
You must be signed in to change notification settings - Fork 51
chore(rai-perception): remove dual package management #711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@maciejmajek, thanks for catching the missed doc changes. The launch file removals look good. Regarding the setup file changes: I’m ambivalent. Until we publish |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #711 +/- ##
=======================================
Coverage 65.32% 65.32%
=======================================
Files 78 78
Lines 3386 3386
=======================================
Hits 2212 2212
Misses 1174 1174 ☔ View full report in Codecov by Sentry. |
Juliaj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Purpose
Simplifying rai-perception package management to pyproject.toml only
Proposed Changes
Removing ros2 setup files and launchfiles
Issues
Testing