[examples] Add ktx2 textures to sun.gltf #21249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Un-embed its resources per our current conventions.
jwnimmer-tri
added
status: single reviewer ok
|
+@SeanCurtis-TRI for both reviews, please. This is pushing the limit of model files we keep in I am open to moving the |
There was a problem hiding this comment.
I'm fine with leaving it here. It's no closer to the limit than it was before and it helps keep the example 100% self-contained -- people doesn't have to understand voodoo about @drake_models to "get it".
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status:complete! all discussions resolved, LGTM from assignee SeanCurtis-TRI(platform)
RussTedrake
pushed a commit
to RussTedrake/drake
that referenced
this pull request
Dec 15, 2024
Un-embed its resources per our current conventions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Un-embed its resources per our current conventions.
Towards #20935.
This change is