Revert "pybind11: Use workaround for false cache hits for overloads" #12105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avalenzu
commented
Sep 26, 2019
There was a problem hiding this comment.
@drake-jenkins-bot mac-mojave-clang-bazel-experimental-release please.
@jamiesnape, what other mac builds should I run for this? Thanks!
Reviewable status: needs platform reviewer assigned, needs at least two assigned reviewers
|
@drake-jenkins-bot mac-mojave-clang-bazel-experimental-release please. |
jwnimmer-tri
added
the
status: single reviewer ok
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status: LGTM missing from assignee EricCousineau-TRI(platform) (waiting on @EricCousineau-TRI)
|
:( Re-opened issue #11424 \cc @BetsyMcPhail |
avalenzu
commented
Sep 26, 2019
There was a problem hiding this comment.
Reviewable status:
complete! all discussions resolved, LGTM from assignee jwnimmer-tri(platform)
EricCousineau-TRI
pushed a commit
to RobotLocomotion/pybind11
that referenced
this pull request
Jan 14, 2020
…#35) Reverts #32 This change cause segfaults on Mac CI: RobotLocomotion/drake#12105 This was PR'd against this pybind11 fork and merged, then incorporated into a Drake PR as a commit update. The Drake PR was then reverted in #12105, but the commit was not reverted in pybind11 itself, hence this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear @EricCousineau-TRI ,
The on-call build cop, @avalenzu, believes that your PR #12095 may have
broken one or more of Drake's continuous integration builds [1]. It is
possible to break a build even if your PR passed continuous integration
pre-merge because additional platforms are tested post-merge.
The specific build failures under investigation are:
https://drake-jenkins.csail.mit.edu/view/Production/job/mac-mojave-unprovisioned-clang-bazel-nightly-release/73/
https://drake-jenkins.csail.mit.edu/view/Production/job/mac-mojave-clang-bazel-nightly-everything-release/72/
https://drake-jenkins.csail.mit.edu/view/Continuous%20Production/job/mac-mojave-clang-bazel-continuous-release/147/
Therefore, the build cop has created this revert PR and started a complete
post-merge build to determine whether your PR was in fact the cause of the
problem. If that build passes, this revert PR will be merged 60 minutes from
now. You can then fix the problem at your leisure, and send a new PR to
reinstate your change.
If you believe your original PR did not actually break the build, please
explain on this thread.
If you believe you can fix the break promptly in lieu of a revert, please
explain on this thread, and send a PR to the build cop for review ASAP.
If you believe your original PR definitely did break the build and should be
reverted, please review and LGTM this PR. This allows the build cop to merge
without waiting for CI results.
For advice on how to handle a build cop revert, see [2].
Thanks!
Your Friendly On-call Build Cop
[1] CI Production Dashboard: https://drake-jenkins.csail.mit.edu/view/Production/
[2] https://drake.mit.edu/buildcop.html#workflow-for-handling-a-build-cop-revert
Workflow for Handling a Build Cop Revert
This change is