Merged
Conversation
* feat: added feature to get paginated request * refactor: removed console and fix api url query
… Page (#712) * feat: show applied filters as badges to indicate the state of page * remove tests * refactor: change rem to px where it is less than one * refactor: optimize showbadges to use single loop to iterate filters * test: add filter and sort tests --------- Co-authored-by: Prakash Choudhary <34452139+prakashchoudhary07@users.noreply.github.com>
…equests page (#717) * fix deleteBadge function * test: add test case for badge deletion via icon click
Fix/resolve conflicts
Deploying dashboard-rds with
|
| Latest commit: |
b409f74
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://398af53e.dashboard-rds.pages.dev |
| Branch Preview URL: | https://develop.dashboard-rds.pages.dev |
prakashchoudhary07
approved these changes
Mar 15, 2024
Achintya-Chatterjee
approved these changes
Mar 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Date: 15-03-2023
Developer Name: @VinayakaHegade
PRs Going in Sync:
All the other changes were already synced to main in #706
Issue Ticket Number
#715
Description
deleteBadgefunction was not correctly deleting badges when the delete icon was clicked.deleteBadgefunction was usinge.target.textContentto identify the badge to delete. However, when the delete icon (an image element) was clicked,e.targetwas the image element, which doesn't have atextContentproperty.deleteBadgefunction has been updated to use theElement.closest()method to find the closest ancestor with the class 'badge' and get thetextContentof span inside it.Documentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
Staging Proof for #717
staging-proof-badges-fix.mp4
Test Coverage
Screenshot 1
Additional Notes