Fix: selected filters badge deletion when x icon is clicked in task-requests page#717
Merged
prakashchoudhary07 merged 2 commits intodevelopfrom Mar 15, 2024
Merged
Fix: selected filters badge deletion when x icon is clicked in task-requests page#717prakashchoudhary07 merged 2 commits intodevelopfrom
prakashchoudhary07 merged 2 commits intodevelopfrom
Conversation
Deploying dashboard-rds with
|
| Latest commit: |
802f4dd
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c2398a2e.dashboard-rds.pages.dev |
| Branch Preview URL: | https://fix-delete-badge.dashboard-rds.pages.dev |
Achintya-Chatterjee
approved these changes
Mar 15, 2024
prakashchoudhary07
approved these changes
Mar 15, 2024
rahul-singh04
pushed a commit
to rahul-singh04/website-dashboard
that referenced
this pull request
Mar 24, 2024
…equests page (RealDevSquad#717) * fix deleteBadge function * test: add test case for badge deletion via icon click
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Date: 15-03-2024
Developer Name: @VinayakaHegade
Issue Ticket Number
closes #715
Description
deleteBadgefunction was not correctly deleting badges when the delete icon was clicked.deleteBadgefunction was usinge.target.textContentto identify the badge to delete. However, when the delete icon (an image element) was clicked,e.targetwas the image element, which doesn't have atextContentproperty.deleteBadgefunction has been updated to use theElement.closest()method to find the closest ancestor with the class 'badge' and get thetextContentof span inside it.Documentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
Before the fix
filter-badge-bug.mp4
After the fix
fix-delete-badge.mp4
Test Coverage
Screenshot 1
Additional Notes