feature: request management system page by Swapnil099 · Pull Request #701 · RealDevSquad/website-dashboard

Swapnil099 · 2024-02-18T17:21:57Z

Date: 18 Feb 2024

Developer Name: Swapnil Gawande

Issue Ticket Number

693

Description

This PR consists of html , css and Js code for new Out-Of-Office requests listings UI.

Integrated OOO requests listing API along with the UI.
Integrated OOO requests accept/reject API with UI.
Added sort and filter functionality for OOO requests.

Documentation Updated?

Yes
[✓] No

Under Feature Flag

[✓] Yes
No

Database Changes

Yes
[✓] No

Breaking Changes

Yes
[✓] No

Development Tested?

[✓] Yes
No

Screenshots

Mobile and Destop View Screenshort as test with local backend setup APIs.

Test Coverage

Screenshot 1

Additional Notes

requests/constants.js

requests/assets/RDSLogo.png

requests/index.html

sahsisunny · 2024-02-20T14:29:02Z

No OOO requests found! message should be in the center of the screen

sahsisunny · 2024-02-20T14:29:31Z

OOO tab name should be OOO not Ooo

sahsisunny · 2024-02-20T14:31:22Z

Can you change the style of the selector like this? The arrow icon should rotate based on the state of the selector, and we can call the API based on the selection. I don't think we need to click on the search button until we have added text to search input.

sahsisunny · 2024-02-20T14:38:14Z

Recording.2024-02-20.200740.mp4

please observe and fix this issue

issue :

Swapnil099 · 2024-02-21T08:56:55Z

Recording.2024-02-20.200740.mp4
please observe and fix this issue

issue :

@sahsisunny, The PUT api to update OOO request does not accept "Reason" as a "Null" value. that why this error is coming. I think we should make the API accept "Reason" as a "Null" value because in some cases admin might just accept request without any reason. what's your thought on this ?

sahsisunny · 2024-02-21T09:14:41Z

Recording.2024-02-20.200740.mp4
please observe and fix this issue

issue :

@sahsisunny, The PUT api to update OOO request does not accept "Reason" as a "Null" value. that why this error is coming. I think we should make the API accept "Reason" as a "Null" value because in some cases admin might just accept request without any reason. what's your thought on this ?

When the reason is null then not send in the body

Swapnil099 · 2024-02-21T09:16:24Z

Recording.2024-02-20.200740.mp4
please observe and fix this issue
issue :

@sahsisunny, The PUT api to update OOO request does not accept "Reason" as a "Null" value. that why this error is coming. I think we should make the API accept "Reason" as a "Null" value because in some cases admin might just accept request without any reason. what's your thought on this ?

When the reason is null then not send in the body

Okay got it

Swapnil099 · 2024-02-21T09:43:52Z

No OOO requests found! message should be in the center of the screen

This change is implemented. please check.

Swapnil099 · 2024-02-21T09:44:32Z

OOO tab name should be OOO not Ooo

Tab name is changes to "OOO.

Swapnil099 · 2024-02-21T09:45:05Z

Can you change the style of the selector like this? The arrow icon should rotate based on the state of the selector, and we can call the API based on the selection. I don't think we need to click on the search button until we have added text to search input.

suggested icon change is done.

Swapnil099 · 2024-02-21T09:46:17Z

Recording.2024-02-20.200740.mp4
please observe and fix this issue
issue :

@sahsisunny, The PUT api to update OOO request does not accept "Reason" as a "Null" value. that why this error is coming. I think we should make the API accept "Reason" as a "Null" value because in some cases admin might just accept request without any reason. what's your thought on this ?

When the reason is null then not send in the body

Change implemented as per suggestion. now accept/reject functionality working fine without remark.

sahsisunny · 2024-02-21T14:01:42Z

triangle icon should be clickable

sahsisunny · 2024-02-21T14:04:52Z

UI is breaking

sahsisunny · 2024-02-21T14:05:42Z

Can you also add query param for tabs and filters?

For tab:

http://localhost:5500/requests/?q=type:OOO+state:PENDING

…99/website-dashboard into feat/oooRequest/listing

Swapnil099 · 2024-02-22T14:25:48Z

UI is breaking

this issue is now fixed. please check.

Swapnil099 · 2024-02-22T14:26:12Z

triangle icon should be clickable

icon is now clickable.

Swapnil099 · 2024-02-22T14:33:22Z

Can you also add query param for tabs and filters?

For tab:

http://localhost:5500/requests/?q=type:OOO+state:PENDING

I will have to research on how to get this done. can we add this to the next task/PR?

Swapnil099 · 2024-02-24T11:44:50Z

Amd author name "Real Dev Squad" in mera tag

change done.

Swapnil099 · 2024-02-24T11:45:14Z

Why tabs are shifting when toast is showing?
now made it overlap.

sahsisunny

please link the issue ticket for test cases

requests/script.js

…racted for createOooCard method

requests/util.js

Achintya-Chatterjee

@Swapnil099 Add a working proof for the whole feature. I'm not seeing any videos

Achintya-Chatterjee

@Swapnil099 where is the tests for this feature?

Swapnil099 · 2024-02-25T15:41:47Z

@Swapnil099 Add a working proof for the whole feature. I'm not seeing any videos
Here is the working proof. Please check.

Ooo_working_proof.mp4

Swapnil099 · 2024-02-25T15:45:07Z

@Swapnil099 where is the tests for this feature?
Test cases have not been written yet, as I thought they would be added in the next task, can I write them in the next PR/Task?

…ions

Achintya-Chatterjee

Did you put this feature behind the feature flag? I'm not seeing a feature flag in your working proof.

Swapnil099 · 2024-02-25T17:35:37Z

Did you put this feature behind the feature flag? I'm not seeing a feature flag in your working proof.

Added dev feature flag. The video is attached.
CC: @sahsisunny can you please check and confirm?

ooo_dev_flag.mp4

Achintya-Chatterjee · 2024-02-26T07:40:24Z

@Swapnil099 where are the tests for this feature?
Test cases have not been written yet, as I thought they would be added in the next task, can I write them in the next PR/Task?

@Swapnil099 open an issue ticket for test and assign this ticket yourself

Achintya-Chatterjee · 2024-02-26T07:43:01Z

Did you put this feature behind the feature flag? I'm not seeing a feature flag in your working proof.

Added dev feature flag. The video is attached. CC: @sahsisunny can you please check and confirm?

ooo_dev_flag.mp4

Why it's showing N/A in the name field?

Swapnil099 · 2024-02-26T07:50:54Z

Did you put this feature behind the feature flag? I'm not seeing a feature flag in your working proof.

Added dev feature flag. The video is attached. CC: @sahsisunny can you please check and confirm?
ooo_dev_flag.mp4

Why it's showing N/A in the name field?

I had set first_name to null in my local DB for testing the edge cases where user first_name is not available. that's why it is showing N/a here.

Swapnil099 · 2024-02-26T07:52:36Z

@Swapnil099 where are the tests for this feature?
Test cases have not been written yet, as I thought they would be added in the next task, can I write them in the next PR/Task?

@Swapnil099 open an issue ticket for test and assign this ticket yourself

okay

Achintya-Chatterjee · 2024-02-26T08:47:25Z

Did you put this feature behind the feature flag? I'm not seeing a feature flag in your working proof.

Added dev feature flag. The video is attached. CC: @sahsisunny can you please check and confirm?
ooo_dev_flag.mp4

Why it's showing N/A in the name field?

I had set first_name to null in my local DB for testing the edge cases where user first_name is not available. that's why it is showing N/a here.

okay, No worries

requests/script.js

Swapnil099 added 2 commits February 17, 2024 15:38

ooo requests listing and accept-reject functionality implemented

b0572df

changes in sort and filter UI

9fd8d67