Skip to content

Comments

Dev to Main Sync#706

Merged
iamitprakash merged 5 commits intomainfrom
develop
Mar 14, 2024
Merged

Dev to Main Sync#706
iamitprakash merged 5 commits intomainfrom
develop

Conversation

@Achintya-Chatterjee
Copy link
Contributor

@Achintya-Chatterjee Achintya-Chatterjee commented Mar 1, 2024

Date: 13-03-2024

Developer Name: @VinayakaHegade


PRs Going in Sync:

Issue Ticket Number

closes #696

Description

Documentation Updated?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Screenshots

Staging proof for #712

filter-badges-staging.mp4

Test Coverage

Screenshot 1

dashboard-tests

Additional Notes

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Mar 5, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: f183d11
Status: ✅  Deploy successful!
Preview URL: https://edb422c5.dashboard-rds.pages.dev
Branch Preview URL: https://develop.dashboard-rds.pages.dev

View logs

sahsisunny and others added 2 commits March 12, 2024 22:00
* feat: added feature to get paginated request

* refactor: removed console and fix api url query
… Page (#712)

* feat: show applied filters as badges to indicate the state of page

* remove tests

* refactor: change rem to px where it is less than one

* refactor: optimize showbadges to use single loop to iterate filters

* test: add filter and sort tests

---------

Co-authored-by: Prakash Choudhary <34452139+prakashchoudhary07@users.noreply.github.com>
@Achintya-Chatterjee Achintya-Chatterjee self-assigned this Mar 13, 2024
@iamitprakash iamitprakash merged commit d63d274 into main Mar 14, 2024
@sahsisunny
Copy link
Contributor

sahsisunny commented Mar 14, 2024

@VinayakaHegade VinayakaHegade mentioned this pull request Mar 15, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants