Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include missing vtkTexture.h. Follow up on #2291 #2316

Merged
merged 1 commit into from
May 20, 2018

Conversation

jasjuang
Copy link
Contributor

This is a follow up on #2291. I forgot to include the header vtkTexture.h. We need this otherwise it won't compile. I discovered this after a fresh clone on a new computer. My bad on not realizing this earlier.

@SergioRAgostinho
Copy link
Member

I'm not sure if it's relevant or not, but vtkTexture.h was added in VTK 6.

@jasjuang
Copy link
Contributor Author

@SergioRAgostinho I originally put VTK_MAJOR_VERSION > 5 on the vtkTexture related code in #2291, but it got changed to VTK_MAJOR_VERSION < 8 in #2311, so I am trying to make it consistent with #2311.

@SergioRAgostinho
Copy link
Member

👍 Thanks for the clarification. FYI, CI is failing with the changes.

@jasjuang
Copy link
Contributor Author

@SergioRAgostinho The CI is failing on an unit test related to octree. It doesn't seem to be related to the visualizer to me.

@SergioRAgostinho SergioRAgostinho merged commit d1c9870 into PointCloudLibrary:master May 20, 2018
@SergioRAgostinho
Copy link
Member

My comment was aimed at the original CI report the PR generated, not the current one, after you resubmitted the commit.

Thanks for the submission.

@SergioRAgostinho SergioRAgostinho changed the title fix missing vtkTexture.h, follow up on #2291 Include missing vtkTexture.h. Follow up on #2291 Aug 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants