Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change VTK version check in addTextureMesh #2311

Merged
merged 1 commit into from
May 16, 2018
Merged

Change VTK version check in addTextureMesh #2311

merged 1 commit into from
May 16, 2018

Conversation

taketwo
Copy link
Member

@taketwo taketwo commented May 16, 2018

Fixes an issue introduced by #2291.

@SergioRAgostinho SergioRAgostinho merged commit d5759fd into PointCloudLibrary:master May 16, 2018
@taketwo taketwo deleted the fix-vtk-ifdef branch May 16, 2018 14:31
@achalshah20
Copy link

Should it be if VTK_MAJOR_VERSION > 8 instead of if VTK_MAJOR_VERSION < 8 ?

@taketwo
Copy link
Member Author

taketwo commented May 18, 2018

Why? VTK_MAJOR_VERSION > 8 would mean VTK 9, which does not even exist.

@achalshah20
Copy link

achalshah20 commented May 18, 2018 •
edited
Loading

I figured.
You changed the order of if else blocks. I was comparing with previous commit. it should be fine. My bad!

@jasjuang jasjuang mentioned this pull request May 19, 2018
Merged
Tones29 added a commit to Tones29/pcl that referenced this pull request May 27, 2018
@Tones29
Second change VTK version check in addTextureMesh
e1796cf 
Fixes an issue introduced by PointCloudLibrary#2291 and not completely fixed with  PointCloudLibrary#2311
@Tones29 Tones29 mentioned this pull request May 27, 2018
Merged
@SergioRAgostinho SergioRAgostinho mentioned this pull request Aug 6, 2018
Closed
@SergioRAgostinho SergioRAgostinho mentioned this pull request Aug 25, 2018
Merged
@SergioRAgostinho SergioRAgostinho changed the title Change VTK version check in addTextureMesh Change VTK version check in addTextureMesh Aug 26, 2018
@taketwo taketwo mentioned this pull request Nov 12, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergioRAgostinho SergioRAgostinho SergioRAgostinho approved these changes

Assignees
No one assigned
Labels
module: visualization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@taketwo @achalshah20 @SergioRAgostinho