Skip to content

Conversation

@BoySanic
Copy link
Contributor

@BoySanic BoySanic commented Oct 25, 2025

This PR splits out structures and hashing from biomes.zig into structures.zig and src/utils.zig respectively.

This change should be done for the following reasons:

  1. It cleans up Biome-independent structure tables #2129. A lot.
  2. Splitting it out from biomes.zig into another file makes it a bit cleaner once we add the changes from Biome-independent structure tables #2129 that introduces the StructureTable struct for example. It's technically feasible to leave it all in biomes.zig, splitting it out made the most sense to me at the time for organization purposes.

@nekonesse
Copy link

does this allows addons to add structures to preexisting biomes? 🥺

@BoySanic
Copy link
Contributor Author

does this allows addons to add structures to preexisting biomes? 🥺

With #2129 yes. Not by itself though.

@BoySanic BoySanic moved this to WIP/not ready for review in PRs to review Nov 3, 2025
@BoySanic BoySanic mentioned this pull request Nov 3, 2025
@BoySanic BoySanic moved this from WIP/not ready for review to In review in PRs to review Nov 4, 2025
@BoySanic BoySanic mentioned this pull request Nov 4, 2025
@IntegratedQuantum
Copy link
Member

Seems like I totally missed this, please rebase and I'll review this again.

@BoySanic
Copy link
Contributor Author

I'll get this rebased so we can push it forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In review

Development

Successfully merging this pull request may close these issues.

5 participants