Skip to content

Conversation

@codemob-dev
Copy link
Contributor

Fixes #1539

@codemob-dev codemob-dev moved this to Easy to Review in PRs to review Nov 4, 2025
@BoySanic
Copy link
Contributor

BoySanic commented Nov 4, 2025

This will conflict with #2131 (and maybe #2129 since it depends on #2131) so we'll have to deal with that as it comes

@codemob-dev
Copy link
Contributor Author

This will conflict with #2131 (and maybe #2129 since it depends on #2131) so we'll have to deal with that as it comes

Maybe a little, but the PR is basically 2 lines besides removing the old IDs in the structures and moving the files.

@Argmaster
Copy link
Collaborator

With so many contributors it's inevitable that in busy parts of the codebase there will be conflicts. The sooner we move the code to it's final destination the better. It's up to Quantum anyway.

@IntegratedQuantum
Copy link
Member

I would like to have an answer to #1630 (comment) before I approve any further modding attempts

@IntegratedQuantum IntegratedQuantum moved this from Easy to Review to WIP/not ready for review in PRs to review Nov 6, 2025
@codemob-dev
Copy link
Contributor Author

I would like to have an answer to #1630 (comment) before I approve any further modding attempts

From #1630 (comment) to keep the discussion out of closed PRS:

What if we keep the @ notation in the list struct for use from zon files but have a separate autogenerated struct that uses this syntax for use from the code itself?

@IntegratedQuantum
Copy link
Member

I'd rather not have so many auto-generated files, and having two version of one thing will inevitably get misused.

@codemob-dev
Copy link
Contributor Author

I'd rather not have so many auto-generated files, and having two version of one thing will inevitably get misused.

How would we access this nested struct at runtime then?

@IntegratedQuantum
Copy link
Member

You can't access any struct at runtime, neither the one with @"" nor the one with namespaces.
Runtime mappings are stored in a HashMap.

@codemob-dev
Copy link
Contributor Author

Runtime mappings are stored in a HashMap.

Ah, right.

@codemob-dev codemob-dev marked this pull request as draft November 18, 2025 17:04
@codemob-dev
Copy link
Contributor Author

Closing this because of conflicts and above issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[MODS] Load simple structure generator types from mods directory

4 participants