Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: PathOfBuildingCommunity/PathOfBuilding
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: dev@{1day}
Choose a base ref
...
head repository: PathOfBuildingCommunity/PathOfBuilding
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: dev
Choose a head ref
  • 14 commits
  • 24 files changed
  • 5 contributors

Commits on Nov 4, 2025

  1. Fix Spectre conversion multiplier applying to gain and Chaos damage (#…

    …9168)
    
    The new conversion damage multiplier was meant to only apply to conversion from phys to elemental damage types
    It is also not meant to apply to damage gain mods but since we grouped them into the same multiplier value it was mistakenly working
    
    Co-authored-by: LocalIdentity <localidentity2@gmail.com>
    LocalIdentity and LocalIdentity authored Nov 4, 2025
    Configuration menu
    Copy the full SHA
    2cc49fb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2064829 View commit details
    Browse the repository at this point in the history
  3. Fix incorrect tooltip when crafting some flask mods (#9164)

    When crafting mods on items that used a `less x` mod, we flipped the order of the values so they would smoothly transition between tiers instead of jumping
    e.g. (45-49)% less Duration, (40-44)% less Duration, (35-39)% less Duration
    We didn't update the range slider tooltip though so it was still jumping and was not representing the value on the item
    
    Co-authored-by: LocalIdentity <localidentity2@gmail.com>
    LocalIdentity and LocalIdentity authored Nov 4, 2025
    Configuration menu
    Copy the full SHA
    dab3f7c View commit details
    Browse the repository at this point in the history
  4. Fix mod order when crafting Grafts (#9163)

    Some graft mods had identical statOrder values and the same level requirement so it would then fall back to the random order the pairs list added the mods in
    Instead now we sort based on Id if the statOrder and level values are the same
    Making the change also requires change the lastSeries list to no longer prepend the values
    
    Co-authored-by: LocalIdentity <localidentity2@gmail.com>
    LocalIdentity and LocalIdentity authored Nov 4, 2025
    Configuration menu
    Copy the full SHA
    20018a0 View commit details
    Browse the repository at this point in the history
  5. Fix "Farewell to Flesh" not applying to Agony Crawler ailment damage (#…

    …9162)
    
    The `GetStat` code relied on using `cfg.summonSkillName` to match names for the skills but when we handle the ailments we were not including summonSkillName in the cfg so it would fail to match and not grant Ailment damage to Agony Crawler
    Also added a floor to the returned value as it was a float before
    
    Co-authored-by: LocalIdentity <localidentity2@gmail.com>
    LocalIdentity and LocalIdentity authored Nov 4, 2025
    Configuration menu
    Copy the full SHA
    af39d58 View commit details
    Browse the repository at this point in the history
  6. Fix Pyroclast Mine exposure being inverted and unscaleable (#9160)

    For some reason I was inverting the value of the exposure and also forgot to remove the unscaleable tag from the mod
    
    Co-authored-by: LocalIdentity <localidentity2@gmail.com>
    LocalIdentity and LocalIdentity authored Nov 4, 2025
    Configuration menu
    Copy the full SHA
    7abc4ce View commit details
    Browse the repository at this point in the history
  7. Fix Damage Gain breakdown including skill conversion (#9170)

    The breakdown for skill conversion and damage gained were grouped together to make 1 value instead of being separate table columns
    
    Co-authored-by: LocalIdentity <localidentity2@gmail.com>
    LocalIdentity and LocalIdentity authored Nov 4, 2025
    Configuration menu
    Copy the full SHA
    8a397e0 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2025

  1. Fix insufficient skill cost warning applying to other skills (#9172)

    When checking to see if we should apply the red text to a skills resource cost value we were checking the list of all skills that had a warning for that cost type instead of just the active skill in the sidebar
    Decided to change the variable name for the list so that we can still use other `statData.stat.."Warning"` for other stats if we want
    
    Co-authored-by: LocalIdentity <localidentity2@gmail.com>
    LocalIdentity and LocalIdentity authored Nov 5, 2025
    Configuration menu
    Copy the full SHA
    b8adac5 View commit details
    Browse the repository at this point in the history
  2. Fix some enemy modifiers not working (#9173)

    enemyDB was not populated with `EnemyModifier` mods until doActorMisc was run on line 3078 so all the calls to enemyDB before that could be potentially missing mods
    We now pull the call out of doMisc and run it early in the pass so all the subsequent calls to enemyDB will include them
    
    Co-authored-by: LocalIdentity <localidentity2@gmail.com>
    LocalIdentity and LocalIdentity authored Nov 5, 2025
    Configuration menu
    Copy the full SHA
    b8e9992 View commit details
    Browse the repository at this point in the history
  3. Release 2.58.1 (#9174)

    * Prepare release 2.58.1
    
    * Manifest
    
    ---------
    
    Co-authored-by: LocalIdentity <LocalIdentity@users.noreply.github.com>
    Co-authored-by: LocalIdentity <localidentity2@gmail.com>
    3 people authored Nov 5, 2025
    Configuration menu
    Copy the full SHA
    de43d58 View commit details
    Browse the repository at this point in the history
  4. 3.27.0b export

    Also fixes the export of mods files so the stat orders are not broken anymore
    LocalIdentity committed Nov 5, 2025
    Configuration menu
    Copy the full SHA
    e9373b2 View commit details
    Browse the repository at this point in the history
  5. Merge branch 'dev'

    LocalIdentity committed Nov 5, 2025
    Configuration menu
    Copy the full SHA
    07256d2 View commit details
    Browse the repository at this point in the history
  6. Release 2.58.1

    --- User Interface ---
    - Fix incorrect tooltip when crafting some flask mods (LocalIdentity)
    - Fix Damage Gain breakdown including skill conversion (LocalIdentity)
    - Fix insufficient skill cost warning applying to other skills (LocalIdentity)
    
    --- Fixed Calculations ---
    - Fix Spectre conversion multiplier applying to "gain as x" mods and Chaos damage (LocalIdentity)
    - Fix Pyroclast Mine Exposure being inverted and unscalable (LocalIdentity)
    
    --- Fixed Behaviours ---
    - Fix Intuitive Leap, Thread of Hope and Impossible Escape not parsing correctly (Wires77)
    - Fix mod order when crafting Grafts (LocalIdentity)
    - Fix "Farewell to Flesh" not applying to Agony Crawler ailment damage (LocalIdentity)
    - Fix Dying Breath Curse effect mod not working (LocalIdentity)
    LocalIdentity committed Nov 5, 2025
    Configuration menu
    Copy the full SHA
    5eff6b4 View commit details
    Browse the repository at this point in the history
  7. Merge branch 'master' into dev

    LocalIdentity committed Nov 5, 2025
    Configuration menu
    Copy the full SHA
    58aef43 View commit details
    Browse the repository at this point in the history
Loading