Fix mod order when crafting Grafts #9163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some graft mods had identical statOrder values and the same level requirement so it would then fall back to the random order the pairs list added the mods in Instead now we sort based on Id if the statOrder and level values are the same Making the change also requires change the lastSeries list to no longer prepend the values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9161 .
Description of the problem being solved:
Some graft mods had identical statOrder values and the same level requirement so it would then fall back to the random order the pairs list added the mods in
Instead now we sort based on Id if the statOrder and level values are the same
Making the change also requires change the lastSeries list to no longer prepend the values
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://maxroll.gg/poe/pob/7e6qc0ac
Before screenshot:
After screenshot: