Skip to content

ROS2 Migration #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Dec 24, 2021
Merged

ROS2 Migration #95

merged 12 commits into from
Dec 24, 2021

Conversation

wep21
Copy link

@wep21 wep21 commented Dec 15, 2021 •
edited
Loading

Closes #76

Ros2 migrtion for octomap mapping
1d1cfe9 
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
@wep21 wep21 marked this pull request as draft December 15, 2021 02:14
@wep21
Copy link
Author

wep21 commented Dec 15, 2021

@wxmerkt Could you create ros2 branch? I will change the target branch to ros2.

@wep21 wep21 changed the title Feature/ros2 migration feat: ros2 migration Dec 15, 2021
@wep21 wep21 force-pushed the feature/ros2-migration branch 3 times, most recently from 457c165 to 8961eb5 Compare December 17, 2021 06:48
Ros2 migration for octomap server
fe8ca81 
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
@wep21 wep21 force-pushed the feature/ros2-migration branch from 8961eb5 to fe8ca81 Compare December 17, 2021 06:50
@wep21 wep21 marked this pull request as ready for review December 17, 2021 07:02
@wep21
Copy link
Author

wep21 commented Dec 17, 2021 •
edited
Loading

@wxmerkt This PR is now ready to be reviewed. I appreciate it if you could review this.

@wep21 wep21 force-pushed the feature/ros2-migration branch 4 times, most recently from aae5cff to c480e34 Compare December 17, 2021 07:38
Add build_depends.repos
454ff9e 
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
@wep21 wep21 force-pushed the feature/ros2-migration branch from c480e34 to 2fb793b Compare December 17, 2021 07:49
Update workflow
92ab840 
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
@wep21 wep21 force-pushed the feature/ros2-migration branch from 2fb793b to 92ab840 Compare December 17, 2021 07:55
wep21 added 2 commits December 17, 2021 17:08
fix build error
0c6e04d 
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
fix lint error
1ef0d8e 
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
@wep21
Copy link
Author

wep21 commented Dec 17, 2021

CI result on my fork
https://github.com/wep21/octomap_mapping/actions/runs/1591345804

@wxmerkt
Copy link
Member

wxmerkt commented Dec 17, 2021

@wep21 Thank you very much for the contribution. I'd like to test this locally, likely this weekend or next week. I'll circle back to this PR then. I hope this is okay

@wep21 wep21 mentioned this pull request Dec 19, 2021
Merged
@wxmerkt wxmerkt changed the title feat: ros2 migration ROS2 Migration Dec 21, 2021
@wxmerkt wxmerkt changed the base branch from kinetic-devel to ros2 December 21, 2021 17:23
wep21
wep21 commented Dec 22, 2021
View reviewed changes
wxmerkt
wxmerkt approved these changes Dec 23, 2021
View reviewed changes
Copy link
Member

@wxmerkt wxmerkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your contribution and this effort in migrating to ROS2 @wep21. If you are happy with the changes I've added we can merge and release it.

@wep21
Copy link
Author

wep21 commented Dec 24, 2021

@wxmerkt Thanks, please go ahead.

@wxmerkt wxmerkt merged this pull request into OctoMap:ros2 Dec 24, 2021
@wep21 wep21 deleted the feature/ros2-migration branch January 7, 2022 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxmerkt wxmerkt wxmerkt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

any ROS2 port?
2 participants
@wep21 @wxmerkt