Skip to content

ROS2 Migration #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 21, 2021
Merged

ROS2 Migration #41

merged 8 commits into from
Dec 21, 2021

Conversation

wep21
Copy link

@wep21 wep21 commented Dec 19, 2021

Close #40
Screenshot from 2021-12-20 02-43-35

wep21 added 2 commits December 20, 2021 05:01
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
@wep21
Copy link
Author

wep21 commented Dec 19, 2021

@wxmerkt I would appreciate it if you test the ros2 migration of rviz plugins with OctoMap/octomap_mapping#95.

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
@wep21 wep21 force-pushed the feature/ros2-migration branch from a49fc4b to 369517e Compare December 19, 2021 21:11
@wxmerkt
Copy link
Member

wxmerkt commented Dec 21, 2021

@wep21 thank you very much for the work in upgrading this for ROS2. I am currently testing this locally with the other changes to octomap_mapping. Things are a bit delayed due to rendering issues in RViz2 on rolling and issues creating octomaps from OpenNI2 sensors. Will merge these as soon as I can get a working setup :-)

@wxmerkt wxmerkt changed the base branch from kinetic-devel to ros2 December 21, 2021 14:52
@wxmerkt wxmerkt changed the title Feature/ros2 migration ROS2 Miration Dec 21, 2021
@wxmerkt wxmerkt changed the title ROS2 Miration ROS2 Migration Dec 21, 2021
Copy link
Member

@wxmerkt wxmerkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this effort @wep21. I've tested it and made a modification to make it run on Foxy as well.

@wxmerkt wxmerkt merged commit 146f71a into OctoMap:ros2 Dec 21, 2021
@wxmerkt
Copy link
Member

wxmerkt commented Dec 21, 2021

@cottsay - could you please create octomap_rviz_plugins and octomap_mapping release repositories in ros2-gbp? Many thanks and happy holidays :-)

@nuclearsandwich
Copy link

@wxmerkt https://github.com/ros2-gbp/octomap_rviz_plugins-release and https://github.com/ros2-gbp/octomap_mapping-release have been added to the octomap release team. In the future you can ping me directly for new repository requests as a quirk of our current deployment process means I'm always in the loop.

@wxmerkt
Copy link
Member

wxmerkt commented Dec 21, 2021

Great, thank you for the super-swift action and note @nuclearsandwich - will do :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release for foxy
3 participants