[UI] Add new themes into website #9926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinrrm
force-pushed
the
dev-martinrrm-feature-new-theme
branch
from
e85c08c
to
1b17d73
Compare
martinrrm
force-pushed
the
dev-martinrrm-feature-new-theme
branch
from
1b17d73
to
3ce9603
Compare
martinrrm
force-pushed
the
dev-martinrrm-feature-new-theme
branch
2 times, most recently
from
92afa45
to
3874a9e
Compare
|
@martinrrm Warning should be yellow (bright or dim depending on the base theme) and not orange-ish! It'll be difficult to distinguish error and warning at a glance. When I glanced at this page, I thought both colors were the same. And no, I do not have any issues with recognising colors. Also, Info can be light/dark blue near to the NuGet accent color instead of Grey-ish! |
* home page new theme
* Add new theme to Package List page
* [UI] Package view page new theme
* [UI] Admin pages part 1 * [UI] Admin pages 2 (#9890)
* [UI] Admin pages 3
* [UI] Add theme to shared pages
* [UI] Add new themes to User pages
* New default package img, textare padding, reserved icon * [Dark Theme] Accessibility and UI fixes * Sort by select * default package icon
martinrrm
force-pushed
the
dev-martinrrm-feature-new-theme
branch
from
14aa12b
to
528ea3a
Compare
joelverhagen
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spec: https://github.com/NuGet/Engineering/pull/5209
Main Issue: #8773
Pending work: #9974