Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Add theme to shared pages #9897

Merged

Conversation

martinrrm
Copy link
Contributor

@martinrrm martinrrm commented Apr 1, 2024

Adds new theme to Shared pages

Addresses #9865
Spec: https://github.com/NuGet/Engineering/pull/5209
Main Issue: #8773

Account Certificates (partial functionality in screenshot)

image

Change Email

image

Change Notifications

image

Change Theme

image

Multiselect dropdown (present only in Deprecation tab)

image

@martinrrm martinrrm force-pushed the dev-martinrrm-dark-theme-shared branch from 5fd7804 to 000e4e6 Compare April 8, 2024 18:14
@martinrrm martinrrm force-pushed the dev-martinrrm-dark-theme-organizations branch 3 times, most recently from 0986311 to d9875e5 Compare April 8, 2024 18:36
@martinrrm martinrrm force-pushed the dev-martinrrm-dark-theme-shared branch from 000e4e6 to eb77ff4 Compare April 9, 2024 21:11
@martinrrm martinrrm marked this pull request as ready for review April 9, 2024 21:12
@martinrrm martinrrm requested a review from a team as a code owner April 9, 2024 21:12
@@ -223,7 +223,6 @@
border-radius: var(--Medium, 4px);
border: 2px solid transparent;
box-shadow: none !important;
padding: 5px 12px;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing since it was not doing anything, padding is added with "btn" class

@martinrrm martinrrm marked this pull request as draft April 9, 2024 21:16
@martinrrm martinrrm force-pushed the dev-martinrrm-dark-theme-shared branch from eb77ff4 to 6844abb Compare April 9, 2024 21:20
@@ -30,6 +30,25 @@

@Styles.Render("~/Content/gallery/css/site.min.css")

<script>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moving it here so we can detect the theme before rendering anything in the UI

@martinrrm martinrrm marked this pull request as ready for review April 9, 2024 21:22
@martinrrm martinrrm changed the base branch from dev-martinrrm-dark-theme-organizations to dev-martinrrm-feature-new-theme April 11, 2024 17:10
@martinrrm martinrrm merged commit 10d6cf7 into dev-martinrrm-feature-new-theme Apr 15, 2024
2 checks passed
martinrrm added a commit that referenced this pull request Apr 30, 2024
* [UI] Add theme to shared pages
martinrrm added a commit that referenced this pull request May 7, 2024
* [UI] Add theme to shared pages
martinrrm added a commit that referenced this pull request May 16, 2024
* [UI] Add theme to shared pages
martinrrm added a commit that referenced this pull request May 22, 2024
* [UI] Add theme to shared pages
martinrrm added a commit that referenced this pull request Jun 21, 2024
* [UI] Add theme to shared pages
@joelverhagen joelverhagen deleted the dev-martinrrm-dark-theme-shared branch August 22, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants