Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Add new themes to User pages #9914

Merged

Conversation

martinrrm
Copy link
Contributor

@martinrrm martinrrm commented Apr 11, 2024

@martinrrm martinrrm changed the title Dev martinrrm dark theme user pages [UI] Add new themes to User pages Apr 11, 2024
@martinrrm martinrrm marked this pull request as ready for review April 11, 2024 20:42
@martinrrm martinrrm requested a review from a team as a code owner April 11, 2024 20:42
@martinrrm martinrrm force-pushed the dev-martinrrm-dark-theme-user-pages branch from 1a5b26d to a482ae7 Compare April 11, 2024 21:15
@agr
Copy link
Contributor

agr commented Apr 12, 2024

What's up with thicker bottom borders on inputs? Does it look the same in the light theme?
image

@agr
Copy link
Contributor

agr commented Apr 12, 2024

How does focus indicator look like when navigating from keyboard?

@martinrrm
Copy link
Contributor Author

@agr This is how the Input gray bar looks like in light theme
image

And this is when focused
image

@martinrrm martinrrm requested a review from zhhyu April 18, 2024 18:02
@martinrrm martinrrm merged commit b23f665 into dev-martinrrm-feature-new-theme Apr 18, 2024
2 checks passed
martinrrm added a commit that referenced this pull request Apr 30, 2024
* [UI] Add new themes to User pages
martinrrm added a commit that referenced this pull request May 7, 2024
* [UI] Add new themes to User pages
martinrrm added a commit that referenced this pull request May 8, 2024
* [UI] Add new themes to User pages
martinrrm added a commit that referenced this pull request May 16, 2024
* [UI] Add new themes to User pages
martinrrm added a commit that referenced this pull request May 22, 2024
* [UI] Add new themes to User pages
martinrrm added a commit that referenced this pull request Jun 21, 2024
* [UI] Add new themes to User pages
@joelverhagen joelverhagen deleted the dev-martinrrm-dark-theme-user-pages branch August 22, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants