New default package img, textare padding, reserved icon #10029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinrrm
commented
Jun 20, 2024
| @@ -974,7 +973,7 @@ | |||
| else | |||
| { | |||
| <td tabindex="0" class="package-icon-cell package-warning-icon" aria-label="@packageVersion.PackageWarningIconTitle"> | |||
| <i class="ms-Icon ms-Icon--Warning package-icon" title="@packageVersion.PackageWarningIconTitle"></i> | |||
| <i tabindex="0" class="ms-Icon ms-Icon--Warning package-icon" title="@packageVersion.PackageWarningIconTitle"></i> | |||
There was a problem hiding this comment.
Added tab stop to warning icon in package versions table, this was an accesibility bug
martinrrm
commented
Jun 20, 2024
| <span class="tooltip-wrapper tooltip-with-icon popover right"> | ||
| <span class="arrow"></span> | ||
| <span class="popover-content"> | ||
| @NuGetGallery.Strings.FrameworkFilters_Tooltip | ||
| <a href="@(Model.FrameworksFilteringInformationLink)">Click here to learn more.</a> |
There was a problem hiding this comment.
Moved "Click here to learn more" here so it can be a link, this caused a nested anchor, so I changed it to spans
joelverhagen
approved these changes
Jun 20, 2024
erdembayar
approved these changes
Jun 20, 2024
martinrrm
added a commit
that referenced
this pull request
Jun 21, 2024
* New default package img, textare padding, reserved icon * [Dark Theme] Accessibility and UI fixes * Sort by select * default package icon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #9964
Prefix reserved and default icon
Sort by select size fixed and default icon on dark mode
Padding is the same on text area and select