Master #167
Closed
Master #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Mixcloud section was commented as "Bandcamp". Also added more #'s for better visual distinction. 😁
When only the artist's username is provided, make sure we always visit the /music page instead of whatever the main page redirects us to (usually redirects to the /releases or the /merch page).
If the JSON routine fails, the new code attempts to parse the URL as a /music page, trying to return a list of album URLs. The calling method now recursively downloads each album if the new code successfully returns a list.
Small fix regarding the saved files when using "-f". Small note added to the Bandcamp section, regarding the newly introduced bug when using "-n".
Reminder: using the browser editor is usually a bad idea 😑
Allow Bandcamp to parse and download all albums
[[1]] Correct album title is now retrieved more reliably, even for "orphan tracks" (tracks without an album). [[2]] The "genre" audio tag is now set using the artist's Bandcamp tags. [[3]] My previous regex is now fixed to also match "orphan tracks" from the /music page. [[4]] The check for already downloaded songs now works even without the "-f" flag (see notes). [[5]] Name formatting is fixed for "orphan tracks" and also for downloading without the "-f" flag. [[6]] Any audio tags already set in a downloaded file are now erased to avoid problems. [[7]] Fixed an error when trying to parse undefined year data of certain "orphan tracks". [[Notes]] Improvement 4 could be replicated to other methods and raises an idea for a "-r" flag to forcefully redownload songs.
The recursive call of the Bandcamp scraper now doesn't break the "--open" option anymore. Additionally, "orphan tracks" (tracks that do not belong to any album) are now download to a folder with the artist's name when using "-f".
Multiple Bandcamp-related improvements
We should only "flatten" the output list if necessary, otherwise the filename gets split into single characters and the "--open" option doesn't work.
Fix issue #38 for non-recursive Bandcamp scraping
Shrinking the array to get around an issue whereby the number of files being scraped wasn't being respected
download_tracks() (and some other functions) didn't check if file is already downloaded when launched without -f argument, now they do. Removed print(e) in download_tracks(), because it can cause crash on Windows. It's actually a good idea to remove all exception printing where there can be unicode characters, because they can cause crash on Windows.
NUM_TRACKS fails under some circumstances
This PR adds support for musicbed.com. This is done using new process_musicbed() function. It also adds 2 new arguments to SoundScrape: -L or --login sets login text. -P or --password sets password text. process_musicbed() requires login and password information in order to download full songs from the site. It will notify user if he/she forgot to set their login and/or password. Of course these arguments can be also used in different plugins if they would need them. Also download_file() function is modified in order to OPTIONALLY download using Session object and/or params. These changes were required for process_musicbed() to do it's job. No other plugins should be affected by this change. At last test.py was updated with musicbed test. I made several tests, fixed errors I could find, so far it seems to be stable.
Adds support for MusicBed.com (#153)
Typo in argparse description
|
This PR is very stale, into a branch that itself is very stale. MixCloud support was experimental and has been broken for a while. Before work started on PR #241, it was already broken and was removed in that PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.