Adds support for MusicBed.com (#153) #155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds support for musicbed.com. This is done using new process_musicbed() function. It also adds 2 new arguments to SoundScrape: -L or --login sets login text. -P or --password sets password text. process_musicbed() requires login and password information in order to download full songs from the site. It will notify user if he/she forgot to set their login and/or password. Of course these arguments can be also used in different plugins if they would need them. Also download_file() function is modified in order to OPTIONALLY download using Session object and/or params. These changes were required for process_musicbed() to do it's job. No other plugins should be affected by this change. At last test.py was updated with musicbed test. I made several tests, fixed errors I could find, so far it seems to be stable.
Contributor
Author
|
Every test passes on my machine when ran locally. I have no idea what travis doesn't like. |
Owner
|
Yeah, it's really annoying, it looks like they're blocking the Travis IP
maybe? I don't know why
…On Wed, Jan 11, 2017 at 9:10 AM, brachna ***@***.***> wrote:
Every test passes on my machine when ran locally. I have no idea what
travis doesn't like.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#155 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAIi04sFHHVOb3857A7O4HnqhF8ESB_cks5rROLwgaJpZM4LgnFj>
.
|
Contributor
Author
|
Ok, looking at travis logs - it's MixCloud test that's failing, not MusicBed. So what do you think of this PR? Any changes? |
Owner
|
I don't know why we're adding this, but hey, it's a great PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for musicbed.com.
This is done using new process_musicbed() function.
It also adds 2 new arguments to SoundScrape:
-L or --login sets login text.
-P or --password sets password text.
process_musicbed() requires login and password information in order to
download full songs from the site.
It will notify user if he/she forgot to set their login and/or password.
Of course these arguments can be also used in different plugins if they
would need them.
Also download_file() function is modified in order to OPTIONALLY download using
Session object and/or params. These changes were required for
process_musicbed() to do it's job. No other plugins should be affected by
this change.
At last test.py was updated with musicbed test.
I made several tests, fixed errors I could find, so far it seems to be
stable.