Skip to content

Conversation

@SimplicityGuy
Copy link

@SimplicityGuy SimplicityGuy commented May 24, 2020

A bunch of major changes in this release!

Build/CI changes:

  • Moved from Travis-CI to GitHub Actions.
  • Adding flake8 linter and black formatting.
  • Moved from the old nose test format to pytest.
  • Updated tests and removed broken tests.

Breaking changes:

  • Removed support for Python 2.7.
  • Removed support for Python 3.4, 3.5, 3.6 (so that filename sanitization can utilize a new package instead of reinventing it).
  • Removed support for hive.co as this was experimental and did not work.
  • Removed support for MixCloud as this was experimental and did not work due to changes in MixCloud's page layout.
  • Removed support for skipping preview tracks due to data not existing in the response from SoundCloud.

Fixes:

  • Improved handling for cases where SoundCloud's API does not work as expected. This includes adding the ability to pull tracks from an RSS feed.
  • Improved error handling for ID3 tagging.
  • Improved error handling for SoundCloud HTTP responses.
  • Refactoring of nearly identical code for better code reuse.
  • Fixing playlist and sets download from SoundCloud.

@SimplicityGuy
Copy link
Author

SimplicityGuy commented Aug 1, 2020

@Miserlou bump. I'd like to get a second set of eyes on the changes here. I know it's a big change.

@grea09
Copy link

grea09 commented Aug 3, 2020

It solved issues with filenames but broke the ability to download from likes apparently.

Here is an error on the UTF-8 test playlist I made:

$ soundscrape -f https://soundcloud.com/grea09/sets/utf8-test
...
Problem getting track data from: https://api.soundcloud.com/i1/tracks/Shogo Nomura'/streams/?client_id=OmTFHKYSMLFqnu2HHucmclAptedxWXkq&app_version=1481046241
Problem downloading すすめ!うちゅうひこうし
...

Here is the error with likes:

$ soundscrape -f https://soundcloud.com/grea09/likes
Problem getting track data from: https://api.soundcloud.com/i1/tracks/Expecting value: line 1 column 1 (char 0)/streams/?client_id=OmTFHKYSMLFqnu2HHucmclAptedxWXkq&app_version=1481046241

Thank you for the good work on the tool fixing those previous issues !

@ldexterldesign
Copy link

ldexterldesign commented Aug 4, 2020

@SimplicityGuy 💋

Currently resorting to https://github.com/flyingrub/scdl but relieved to see this project is still going

Sincerely

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants