--open does not work with bandcamp artists with multiple albums

[Miserlou]

soundscrape -of https://mrcarmack.bandcamp.com/

Downloading: Strolling
[################################] 4505/4505 - 00:01:10

Traceback (most recent call last):
File "/usr/local/bin/soundscrape", line 11, in
sys.exit(main())
File "/usr/local/lib/python2.7/site-packages/soundscrape/soundscrape.py", line 67, in main
process_bandcamp(vargs)
File "/usr/local/lib/python2.7/site-packages/soundscrape/soundscrape.py", line 247, in process_bandcamp
open_files(filenames)
File "/usr/local/lib/python2.7/site-packages/soundscrape/soundscrape.py", line 621, in open_files
process = Popen(command, stdout=PIPE, stderr=PIPE)
File "/usr/local/Cellar/python/2.7.10_1/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 710, in init
errread, errwrite)
File "/usr/local/Cellar/python/2.7.10_1/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 1335, in _execute_child
raise child_exception
TypeError: execv() arg 2 must contain only strings

[Miserlou]

Paging @MasterFocus 🔥

[MasterFocus]

😓
Noted. Will take a look more carefully this weekend.
_{I'm right now creating a Pull Request to propose a few more changes to the Bandcamp scraper, but I didn't touch anything related to the filenames variable.}

[MasterFocus]

As of 2095f93, the Bandcamp scraper makes recursive calls when dealing with a /music page. As a consequence, the filenames variable of the process_bandcamp() method contains a list of lists!

😞 My bad. I have found a fix and will commit it before you possibly merge #39.

[MasterFocus]

This can probably be closed now.

On a side note, I'm not really a python programmer, so I'm not familiar with certain tools.
I noticed you did fix some formatting after merging #39 and you asked me here to use pep8ify.
Is that preferred over autopep8?

[Miserlou]

Do you have a test case provided for this yet? :) I'm not sure if it's working or not.. =/

[Miserlou]

Hey @MasterFocus - I'm still finding that Bandcamp opening isn't working properly. :-(

For instance:
soundscrape -of https://braedenbailey.bandcamp.com/track/woo-hah

Downloads, but does not open.

Can you please try to fix this?

re: Tools/style, I don't have too much of a preference, as long as the tests pass and the code is readable!

[MasterFocus]

I will commit a fix now.
Sorry for the delay. It's been a crazy month and the next 30 days or so will be extremely busy for me.
I'll definitely read more about using these tools and creating proper tests in the future. ;)

[Miserlou]

I understand, no worries! Looking forward to your fix, I hope this gets you
more involved with contributing to open source software!

Thanks again,

On Wed, Nov 18, 2015 at 12:19 PM, Antonio notifications@github.com wrote:

I will commit a fix now.
Sorry for the delay. It's been a crazy month and the next 30 days or so
will be extremely busy for me.
I'll definitely read more about using these tools and creating proper
tests in the future. ;)

—
Reply to this email directly or view it on GitHub
#38 (comment)
.

[Miserlou]

I believe this is fixed in 0.22.1