Skip to content

Version v10.18.2 RC #15454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Aug 4, 2022
Merged

Version v10.18.2 RC #15454

merged 14 commits into from
Aug 4, 2022

Conversation

@metamaskbot
Copy link
Collaborator

@metamaskbot metamaskbot commented Aug 3, 2022

📦 🚀

metamaskbot and others added 13 commits August 3, 2022 20:57
@metamaskbot
Version v10.18.2
f503a63
@adonesky1 @danjm
Fix error that occurs when attempting to display transaction value fo…
d363bdb 
…r an approval transaction with no value argument in the transaction data (#15398)
@danjm
Fix optimism send flow (#15419)
8b4e046
@adonesky1 @danjm
Enhance approval screen title logic (#15406)
29c7f22
@brad-decker @danjm
fix issues relating to race conditions where draftTx does not exist (#…
4c4ce83 
…15420)

* fix issues relating to race conditions where draftTx does not exist

* add another fail safe for inflight initializations
@brad-decker @danjm
remove unnecessary usage of renderableGasButton logic (#15422)
109e46c
@danjm @brad-decker
Stop throwing an error when adding gas defaults for a simple send, th…
50f8be1 
…at has data, to an address without a response code (#15424)

* Stop throwing an error when adding gas defaults for a simple send, that has data, to an address without a response code

* Lint fix

* fixup lint

Co-authored-by: brad-decker <bhdecker84@gmail.com>
@adonesky1 @danjm
add access protection to the getNativeCurrencyImage selector in case …
47ae0de 
…it is the source of a mysterious bug on firefox (#15425)
@ryanml @danjm
Opening Network Forms in full screen from the popup view (#15442)
b6d5872
@danjm
Ensure that if max is selected in send flow, the correct value is set…
d5b95d6 
… after network switch (#15444)
@brad-decker @danjm
add safegaurd for missing account in action (#15450)
1073b4a 
* add safegaurd for missing account in action

* add test to cover case
@danjm
Ensure smart contract interactions are properly represented on the co…
a4f0944 
…nfirm screen (#15446)

* Ensure smart contract interactions are properly represented on the confirm screen

* Fix unit tests

* Code cleanup

* Cleanup

* Code cleanup

* Fix test
@brad-decker @danjm
Use fromAccount instead of selectedAcccount for account updates on ed…
71dd397 
…it (#15449)
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2022

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator Author

metamaskbot commented Aug 3, 2022

Builds ready [71dd397]
Page Load Metrics (1763 ± 40 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint841920201395190
domContentLoaded1588192417518240
load1588192417638440
domInteractive1588192417518240

highlights:

storybook

@danjm
Update changelog v10.18.2 (#15455)
298c2d8 
* Update changelog v10.18.2

* Update CHANGELOG.md
@danjm danjm marked this pull request as ready for review August 4, 2022 15:31
@danjm danjm requested a review from a team as a code owner August 4, 2022 15:31
@danjm danjm requested a review from Gtonizuka August 4, 2022 15:31
@metamaskbot
Copy link
Collaborator Author

metamaskbot commented Aug 4, 2022

Builds ready [298c2d8]
Page Load Metrics (1698 ± 80 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint783011104722
domContentLoaded15192333168817081
load15362333169816680
domInteractive15192333168817081

highlights:

storybook

@danjm danjm merged commit 11763a1 into master Aug 4, 2022
@danjm danjm deleted the Version-v10.18.2 branch August 4, 2022 17:38
@github-actions github-actions bot locked and limited conversation to collaborators Aug 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Gtonizuka Gtonizuka Awaiting requested review from Gtonizuka Gtonizuka was automatically assigned from MetaMask/extension-devs

1 more reviewer

@danjm danjm danjm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@metamaskbot @danjm @adonesky1 @brad-decker @ryanml